Define when gUM rejects with required PTZ constraints #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaufortfrancois
changed the title
reillyeon
approved these changes
Jun 15, 2020
|
Done in 9ab6635 |
|
@reillyeon The issue I'm seeing is that we would currently simply reject the |
|
I guess this is an implementation issue actually. @riju If that looks good to you as well, please merge. |
|
Looks good, I guess we need to keep a track of this bug, which can help Chrome in not leaking information. |
riju
approved these changes
Jun 16, 2020
|
Will track w3c/mediacapture-main#697 |
|
And I've created #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @guidou, we should make it clear how
getUserMedia()can reject when PTZ constraints are required.This currently means
getUserMedia({video: {pan: 1}})for instance rejects with anOverConstrainedError. We should think about how to make sure we don't leak camera PTZ capabilities when user didn't grant access yet.@reillyeon @eehakkin @riju @andypaicu