Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on jQuery #264

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Drop dependency on jQuery #264

merged 1 commit into from
Dec 4, 2020

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Nov 27, 2020

This update re-writes the calls to jQuery using regular DOM functions and drops the dependency on jQuery. See related discussion in #263 (comment)

The generated HTML with the new media-source.js file is exactly the same as before (I also checked with a few byte stream format specs).


Preview | Diff

This update re-writes the calls to jQuery using regular DOM functions and drops
the dependency on jQuery.
@tidoust tidoust requested a review from wolenetz November 27, 2020 18:47
Copy link
Member

@wolenetz wolenetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@tidoust tidoust merged commit 171f66d into w3c:gh-pages Dec 4, 2020
tidoust added a commit to w3c/mse-byte-stream-format-registry that referenced this pull request Dec 7, 2020
No need to retrieve jQuery anymore, as the `media-source.js` script no longer
depends on it, see:
w3c/media-source#264
tidoust added a commit to w3c/mse-byte-stream-format-mp2t that referenced this pull request Dec 7, 2020
No need to retrieve jQuery anymore, as the `media-source.js` script no longer
depends on it, see:
w3c/media-source#264
tidoust added a commit to w3c/mse-byte-stream-format-mpeg-audio that referenced this pull request Dec 7, 2020
No need to retrieve jQuery anymore, as the `media-source.js` script no longer
depends on it, see:
w3c/media-source#264
tidoust added a commit to w3c/mse-byte-stream-format-webm that referenced this pull request Dec 7, 2020
No need to retrieve jQuery anymore, as the `media-source.js` script no longer
depends on it, see:
w3c/media-source#264
tidoust added a commit to w3c/mse-byte-stream-format-isobmff that referenced this pull request Dec 7, 2020
No need to retrieve jQuery anymore, as the `media-source.js` script no longer
depends on it, see:
w3c/media-source#264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants