You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
jyavenard
changed the title
BufferedChangeEventInit shouldn't be optional
BufferedChangeEventInit shouldn't be optional in BufferedChangeEvent constructor
Mar 6, 2024
jyavenard
added a commit
to jyavenard/media-source
that referenced
this issue
Mar 18, 2024
The argument had been made optional by #342 because Web IDL mandates that a dictionary argument must be optional if it has no required fields.
Dropping the optional keyword made the Web IDL invalid again, which triggered the proposed automatic fix in #351 to reintroduce the optional keyword. I'm going to merge #351 to make the Web IDL valid (needed by spec crawlers). If you'd like to make the argument mandatory, that needs to be captured in the construction algorithm (which isn't specified yet, see #345), or something else needs to change.
The constructor of the BufferedChangeEventInit is defined as optional
(https://www.w3.org/TR/media-source/#dom-bufferedchangeevent)
https://www.w3.org/TR/media-source/#dom-bufferedchangeeventinit
Given that a BufferedChangeEvents are always browser generated, making the BufferedChangeEventInit mandatory is preferred.
The text was updated successfully, but these errors were encountered: