Skip to content

Commit

Permalink
Revert VideoConfiguration.framerate to a double. Fixes #12
Browse files Browse the repository at this point in the history
  • Loading branch information
mounirlamouri committed Aug 15, 2019
1 parent a6370dc commit 96c22d3
Showing 1 changed file with 6 additions and 21 deletions.
27 changes: 6 additions & 21 deletions index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ spec: workers; urlPrefix: https://www.w3.org/TR/workers/#
required unsigned long width;
required unsigned long height;
required unsigned long long bitrate;
required DOMString framerate;
required double framerate;
boolean hasAlphaChannel;
};
</pre>
Expand All @@ -327,23 +327,8 @@ spec: workers; urlPrefix: https://www.w3.org/TR/workers/#
abort these steps.
</li>
<li>
If none of the following is true, return <code>false</code> and
abort these steps:
<ul>
<li>
Applying the <a>rules for parsing floating-point number
values</a> to <var>configuration</var>'s
{{VideoConfiguration/framerate}} results in a number that is
finite and greater than 0.
</li>
<li>
<var>configuration</var>'s {{VideoConfiguration/framerate}}
contains one occurrence of U+002F SLASH character (/) and the
substrings before and after this character, when applying the
<a>rules for parsing floating-point number values</a> results in
a number that is finite and greater than 0.
</li>
</ul>
If {{VideoConfiguration/framerate}} is not finite or is not greater
than 0, return <code>false</code> and abort these steps.
</li>
<li>
Return <code>true</code>.
Expand Down Expand Up @@ -372,8 +357,8 @@ spec: workers; urlPrefix: https://www.w3.org/TR/workers/#
<p>
The <dfn for='VideoConfiguration' dict-member>framerate</dfn> member
represents the framerate of the video track. The framerate is the number
of frames used in one second (frames per second). It is represented
either as a double or as a fraction.
of frames used in one second (frames per second). It is represented as a
double.
</p>

<p>
Expand Down Expand Up @@ -1117,7 +1102,7 @@ spec: workers; urlPrefix: https://www.w3.org/TR/workers/#
width : 640,
height : 480,
bitrate : 10000,
framerate : '30'
framerate : 29.97
}
};
navigator.mediaCapabilities.encodingInfo(configuration)
Expand Down

0 comments on commit 96c22d3

Please sign in to comment.