Specify how to handle width/height properties #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred-wang
force-pushed
the
width-height
branch
2 times, most recently
from
e9c4f62 to
aec5669
Compare
This tries to align with Chromium's implementation, see #75 (comment)
fred-wang
force-pushed
the
width-height
branch
from
aec5669 to
fe4c6d4
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 31, 2023
SHA: 4e88a72 Reason: push, by fred-wang Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is basically aligning on Chromium's implementation, with the following tweaks:
https://chromium-review.googlesource.com/c/chromium/src/+/4116578
https://chromium-review.googlesource.com/c/chromium/src/+/4120274
https://chromium-review.googlesource.com/c/chromium/src/+/4043023
See also #75 (comment) for a testcase.
WPT tests will be written later.