-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reserving intent and arg as global attributes #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also your "favorite" attr that should be added to the list: alttext
.
I feel the point of the reserved list of keywords is two fold:
- make attrs that were used in the past that don't affect display be legal so that validators don't complain
- be foreword looking and preemptively get some important MathML 4 attrs into core so validators don't complain.
Besides alttext, I'm not sure what else needs to go in, but I think you may have run up against some others. Maybe not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right about it not being global. Still needs to be reserved though. So the new section you wrote is/was warranted.
Let's wait a day to give others a chance to comment.
@NSoiffer added alttext The current draft schema has
So all now mentioned apart from aria-xxx The comments about preprocessing are a technical limitation of the schema language you can not allow any attribute of name |
If you are adding Symmetrically, you are missing |
(+1 for that statement) Meta note: I thought there was discussion to be had whether ARIA attributes should be added and if so which exact ones would apply. For example, I see Similarly, if we are keeping Maybe the ARIA set is worth a brief discussion and a separate PR? Maybe not, just a thought. |
If we say anything about aria attributes here in Core level 1, I assume we'd treat them like As noted in the schema comment, RelaxNG can't specify |
The braille aria attributes are problematic for math because there are multiple math code in the US (and elsewhere). Hence, even if you know the language of the document, you don't know the appropriate braille to generate. On the other hand, maybe they get added by JS that has found that answer out by some means. The aria braille attrs have cautions that basically say "don't use these unless you really know what you are doing because using them is wrong in most circumstances". As for |
I left a few comments on individual bits, but on further reflection I wonder if |
I understand it's used by existing speech engines that want a complete text replacement for the math, @Steve-Noble (I think) commented before that Pearson make use of this in their e-books. Also while it's not used natively in browsers it is of course available to javascript, currently the full spec draft replaces inline mathml by its alttext if mathml support is not detected (specifically if |
seems like even further reason that maybe we should actually define that one in the spec and just say that browsers may (but don't) do something with it, though other systems may |
Sounds good to me, I'll adjust the text in this branch later. |
To confirm, Peason used the "alttext" element heavily in assessment content (e.g., state math assessments) to enforce very specific text-to-speech renderings of mathematics to ensure that all students are hearing exactly the same reading of the expression which has been approved by state departments of education. I know that Learnosity (another assessment vendor does this as well), and I suspect that others like ETS and AIR may also, but I don't know for sure. Text-to-Speech vendors like Texthelp support this on their end when students use their TTS apps on an assessment. |
…g section as suggested by @bkardell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to follow what's done for sections related to maction/mo/semantics: say that elements accept attributes and that MathML Core does not define any behavior specific to these attributes. And put rationale for including these in non-normative notes.
See
https://w3c.github.io/mathml-core/#enlivening-expressions
https://w3c.github.io/mathml-core/#operator-fence-separator-or-accent-mo
https://w3c.github.io/mathml-core/#semantics-and-presentation
@@ -553,7 +564,7 @@ <h4>The <code>mathvariant</code> attribute</h4> | |||
<code>ssXY</code> properties from [[OPEN-FONT-FORMAT]] | |||
to provide both styles. Page authors may use the | |||
<a data-cite="CSS-FONTS-4#font-variant-alternates-prop"><code>font-variant-alternates</code></a> property with corresponding OpenType font features | |||
to access these glyphs. | |||
to access these glyphs.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this and other unrelated "fix tags" please be done in a separate PR, so this commit is restricted to only the relevant change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only a couple and emacs really doesn't want to save invalid files (I already over-rode it in a few places) so I don't think it's preventing review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, actually I think for this kind of fixes for invalid markup which don't change the content of the spec, you can just go ahead and push the changes without asking a review.
Also "MathML Core" generally refers to itself as "this specification". |
Can ths be merged now so we can finalise a CR draft? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side.
At the core meeting on 2022-06-27 I took an action to add wording adding
intent
andarg
to Core, with no specified behavior at the current level 1 specification. An initial proposal here.