Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexport definitions for the html global attributes #186

Closed
tabatkins opened this issue Feb 10, 2023 · 4 comments
Closed

Unexport definitions for the html global attributes #186

tabatkins opened this issue Feb 10, 2023 · 4 comments

Comments

@tabatkins
Copy link
Member

Currently, mathml-core contains <dfn>s for the HTML global attributes (id, dir, etc). These are just deferring to the HTML definitions (with the exception of dir which has some additional processing rules).

This causes a link conflict for any spec trying to refer to those attributes, requiring the spec author to disambiguate. As far as I can tell, however, there is no need for any spec outside of mathml-core to link to these definitions; they're not intended for global consumption.

Could you mark them as no-export? That would fix the problem for outside specs, and still allow for specs to link directly to mathml-core's versions of the definition if they for some reason found that necessary.

(For now, I'm going to mark the HTML versions as superceding the MathML versions in Bikeshed, but I prefer keeping the special-case exceptions to a minimum.)

@davidcarlisle
Copy link
Collaborator

er yes I guess we'll clear up, I'll ping here when I think it's done for you to confirm

davidcarlisle added a commit that referenced this issue Feb 10, 2023
github-actions bot added a commit that referenced this issue Feb 10, 2023
SHA: 11f8b36
Reason: push, by davidcarlisle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@davidcarlisle
Copy link
Collaborator

@tabatkins respec documents export but not no-export but I see it in the code.

https://respec.org/docs/#data-export

Can you confirm 11f8b36 is what you meant?

@tabatkins
Copy link
Member Author

I'm not familiar with ReSpec internals, but if you're seeing it in the ReSpec code, then yeah.

Assuming that class=no-export is indeed the opposite of class=export, then that fix is 👍

@bkardell
Copy link
Collaborator

@tabatkins we think this is fixed, please reopen if we're wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants