-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: add note on file extension #802
Merged
Merged
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't figure out how to review this... LGTM. |
marcoscaceres
requested changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits... prefer avoiding "official" and RFC2119 keywords in notes.
Co-Authored-By: Marcos Cáceres <[email protected]>
christianliebel
force-pushed
the
extension
branch
from
September 24, 2019 05:34
6246dd7
to
3f8dfe2
Compare
marcoscaceres
approved these changes
Sep 24, 2019
Thanks @christianliebel! |
christianliebel
added a commit
to christianliebel/manifest
that referenced
this pull request
May 27, 2020
Co-Authored-By: Marcos Cáceres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #689
This change (choose one):
changes normative sections without changing behavior)
Commit message:
Editorial: add note on file extension
Preview | Diff