Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: add note on file extension #802

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

christianliebel
Copy link
Member

@christianliebel christianliebel commented Sep 20, 2019

Closes #689

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Commit message:

Editorial: add note on file extension


Preview | Diff

@mgiuca mgiuca self-requested a review September 23, 2019 02:50
@mgiuca
Copy link
Collaborator

mgiuca commented Sep 23, 2019

I can't figure out how to review this... LGTM.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits... prefer avoiding "official" and RFC2119 keywords in notes.

@marcoscaceres marcoscaceres merged commit fef12b3 into w3c:gh-pages Sep 24, 2019
@christianliebel christianliebel deleted the extension branch September 24, 2019 05:39
@marcoscaceres
Copy link
Member

Thanks @christianliebel!

christianliebel added a commit to christianliebel/manifest that referenced this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manifest.webmanifest or manifest.json
3 participants