-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Service Worker registration work properly (don't use outdated steps) #792
Make Service Worker registration work properly (don't use outdated steps) #792
Conversation
index.html
Outdated
A {{Document}} may either be <dfn>installable</dfn> or not. The initial | ||
state of a document is not <a>installable</a>. | ||
</p> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this PR have unrelated changes? It seems so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, yes, this is because GitHub doesn't respect upstream branches in Git. This PR is dependent on #790 which hasn't landed yet, and I don't think there's any way for GitHub to show just the relevant changes.
Please look at this delta.
@marcoscaceres While I'm on a roll with Manifest... Edit: Please look at this delta.
|
5a56e10
to
7a551e3
Compare
The upstream PR has now merged, so this PR's delta is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with caveat the the service worker stuff will be deleted right after (as decided in #800).
Well Jeffrey (talked at TPAC) says to please not do that as he is going to use that innWeb Packaging which uses web app manifest |
@jyasskin could you comment? |
Sure, but the multi-implementer problem remains. Not sure at this point we want to support this in Gecko, but need to check if WebKit supports it. |
We might use the |
Ok, let's proceed with the plan to remove it... we can always bring it back. |
Oops, thanks for closing this out. |
This change (choose one):
changes normative sections without changing behavior)
Commit message:
Make Service Worker registration work properly (don't use outdated steps).
Closes #789.
Preview | Diff