Separate BeforeInstallPrompt from automatic prompt #692
Conversation
| the prompt. | ||
| the prompt. And, the user agent MAY <a>present an install prompt</a> | ||
| at any time, without giving the site an opportunity to prevent it (in | ||
| this case, it is RECOMMENDED that the automated prompt be minimally |
There was a problem hiding this comment.
Technically "be" is correct. Given it's hard to read this sentence, probably best to rephrase as "the automated prompt SHOULD be minimally..."
Edit: This was bothering me (to explain why it should be "be" not "is"), so I checked. So sentences that start with "it is recommended that" use the mandative subjunctive form of the verb, which means the same as the basic imperative form ("to be"), not the present tense ("is"). So:
- "It is recommended that he be quiet", not "It is recommended that he is quiet"
- "It is recommended that she try to eat", not "It is recommended that she tries to eat"
But anyway, I'm just throwing this up as a strawman proposal. I don't intend to commit this in its current form. Just collecting feedback on the proposal.
mgiuca
force-pushed
the
bip-independent-from-auto-prompt
branch
from
016092f to
b2b9170
Compare
mgiuca
force-pushed
the
bip-independent-from-auto-prompt
branch
from
b2b9170 to
5d5e42a
Compare
mgiuca
force-pushed
the
bip-independent-from-auto-prompt
branch
2 times, most recently
from
1472abf to
144c2f5
Compare
mgiuca
force-pushed
the
bip-independent-from-auto-prompt
branch
from
144c2f5 to
4b648a4
Compare
mgiuca
force-pushed
the
bip-independent-from-auto-prompt
branch
from
4b648a4 to
4eca1e9
Compare
|
I’m good with this change, especially given our move to make BIP optional. |
|
Whoa, I forgot about this. Shall we move forward on it? It looks like this resolves the BIP-is-optional thing. I want to review it properly since it's more than a year old and I had previously written "I'm just throwing this up as a strawman proposal. I don't intend to commit this in its current form." |
Preview | Diff