-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(image objects): clarify how to fetch (closes #443) #459
Conversation
Fetching image objects | ||
</h3> | ||
<p> | ||
To <a>fetch</a> and <a>image object</a>, the user agent MUST run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an not and
This looks great to me. The only bit I'm unsure of is if |
If you don't provide a client you should probably provide a referrer and maybe some other data. I guess it might makes sense to not have a client here, since it's a bit separate from the page. Not entirely sure, haven't thought about manifests too much. Still not really sold on them. |
Good point about referrer. Added that to be the manifest's URL, obviously. Will leave the others as is for now and see how we go implementation wise. |
2710bac
to
f4c4505
Compare
* Set the appropriate request props, including referrer.
f4c4505
to
1a918c3
Compare
Referrer policy also needs to come from somewhere. I guess if you don't have a client you'll need some integration with the referrer policy specification then... |
@annevk, we do always have a reference back to the Document and the Link element that kicked off the request. Can we use that as a means to get a suitable client (e.g., the window object)? |
opened #465 |
Yeah, maybe that's better. Although it's a little weird since you can be associated with multiple documents, right? And that document might disappear and then another one might appear? Would that mean you get a new policy? How does CSP work today for manifest resources? |
@jakearchibald WIP, let me know if this is ok?