Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(image objects): clarify how to fetch (closes #443) #459

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

marcoscaceres
Copy link
Member

@jakearchibald WIP, let me know if this is ok?

Fetching image objects
</h3>
<p>
To <a>fetch</a> and <a>image object</a>, the user agent MUST run the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an not and

@jakearchibald
Copy link

This looks great to me. The only bit I'm unsure of is if client should be set or not. Null seems fine since that allows the image to be fetched without a client present, but would like a second opinion from @annevk.

@annevk
Copy link
Member

annevk commented Apr 25, 2016

If you don't provide a client you should probably provide a referrer and maybe some other data. I guess it might makes sense to not have a client here, since it's a bit separate from the page. Not entirely sure, haven't thought about manifests too much. Still not really sold on them.

@marcoscaceres
Copy link
Member Author

If you don't provide a client you should probably provide a referrer

Good point about referrer. Added that to be the manifest's URL, obviously. Will leave the others as is for now and see how we go implementation wise.

@marcoscaceres marcoscaceres force-pushed the Bug_443_fetch_image_objects branch from 2710bac to f4c4505 Compare April 26, 2016 06:17
 * Set the appropriate request props, including referrer.
@marcoscaceres marcoscaceres force-pushed the Bug_443_fetch_image_objects branch from f4c4505 to 1a918c3 Compare April 26, 2016 06:18
@marcoscaceres marcoscaceres merged commit 06f5d7b into gh-pages Apr 26, 2016
@marcoscaceres marcoscaceres deleted the Bug_443_fetch_image_objects branch April 26, 2016 06:23
@annevk
Copy link
Member

annevk commented Apr 26, 2016

Referrer policy also needs to come from somewhere. I guess if you don't have a client you'll need some integration with the referrer policy specification then...

@marcoscaceres
Copy link
Member Author

@annevk, we do always have a reference back to the Document and the Link element that kicked off the request. Can we use that as a means to get a suitable client (e.g., the window object)?

@marcoscaceres
Copy link
Member Author

opened #465

@annevk
Copy link
Member

annevk commented Apr 26, 2016

Yeah, maybe that's better. Although it's a little weird since you can be associated with multiple documents, right? And that document might disappear and then another one might appear? Would that mean you get a new policy?

How does CSP work today for manifest resources?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants