-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steps to install the web application does not take into account whether the installation process was canceled #787
Labels
Comments
5 tasks
mgiuca
added a commit
that referenced
this issue
Sep 26, 2019
Rewrite installation process and install prompting logic per #788. - Introduces a new concept of the document being "installable", a stateful property of the document based on validity of the manifest. - Adds a new process, "steps to determine installability of the document", split out from "steps to install the web application". - Removed the concept of "installation process", "installation succeeded", "installation canceled" (which was unused; see #787) and "installation failed". These concepts are now part of the "steps to install the web application". - "Steps to install the web application" now assumes that the document is installable, and that user has already accepted the install prompt, where previously the determination of installability and prompting were all part of that same process. - Processes that show an install prompt now explicitly call "steps to install the web application" after the user accepts the prompt (see #786). Normative changes are to fix bugs in the spec which made it non-implementable; I believe these simply bring the spec in line with all known implementations, so no implementation change is required due to this spec change. Closes #786, #787, #788.
Closed by #790 |
christianliebel
pushed a commit
to christianliebel/manifest
that referenced
this issue
May 27, 2020
Rewrite installation process and install prompting logic per w3c#788. - Introduces a new concept of the document being "installable", a stateful property of the document based on validity of the manifest. - Adds a new process, "steps to determine installability of the document", split out from "steps to install the web application". - Removed the concept of "installation process", "installation succeeded", "installation canceled" (which was unused; see w3c#787) and "installation failed". These concepts are now part of the "steps to install the web application". - "Steps to install the web application" now assumes that the document is installable, and that user has already accepted the install prompt, where previously the determination of installability and prompting were all part of that same process. - Processes that show an install prompt now explicitly call "steps to install the web application" after the user accepts the prompt (see w3c#786). Normative changes are to fix bugs in the spec which made it non-implementable; I believe these simply bring the spec in line with all known implementations, so no implementation change is required due to this spec change. Closes w3c#786, w3c#787, w3c#788.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The spec defines installation was canceled but this term is never referenced anywhere.
The steps to install the web application trigger the installation process but then proceeds without explicitly checking whether the install was cancelled.
The text was updated successfully, but these errors were encountered: