Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More color contrast non-compliance #432

Closed
nigelmegitt opened this issue Jul 13, 2018 · 1 comment
Closed

More color contrast non-compliance #432

nigelmegitt opened this issue Jul 13, 2018 · 1 comment

Comments

@nigelmegitt
Copy link
Contributor

See #391 for additional links.

The color of code blocks is #C83500 which on the background color of permitted-deprecated blocks (class="deprecation") of #E6E6FA is not WCAG compliant according to snook.ca.

In fact the color of those code blocks is never WCAG 2 AAA compliant even on a white background, but we should at least target AA compliance, which can be achieved by setting the background color to #EBEBFE, which I propose we adopt.

In example fragments, the color of comments in the class hljs-comment is #999988 which on an example background color of #FFFFC8 is non-compliant. There doesn't seem to be any good reason to use this comment class so I propose fixing by just not using it. Then the color of #333333 on that background is compliant.

I've not done an exhaustive check (I suspect there's a tool for that...) but those two caught my eye.

@nigelmegitt
Copy link
Contributor Author

To clarify, the first proposal is to set the background-color of permitted-deprecated blocks to #EBEBFE.

@palemieux palemieux added this to the imsc1.1 PR milestone Jul 17, 2018
palemieux added a commit that referenced this issue Sep 3, 2018
palemieux added a commit that referenced this issue Sep 10, 2018
@palemieux palemieux removed the pr open label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants