This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Port nonce #604
Merged
Port nonce #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewest
reviewed
Sep 29, 2016
| @@ -490,7 +496,9 @@ | |||
| <var>url</var> and <var>corsAttributeState</var>. | |||
| 5. Set <var>request</var>'s <a>client</a> to the <{link}> element's <a>node document</a>'s | |||
| {{Window}} object's <a>environment settings object</a>. | |||
| 6. <a>Fetch</a> <var>request</var>. | |||
| 6. Set <var>request</var>'s <span>cryptographic | |||
| nonce metadata</span> to the current state of the <{link}> element's <a>nonce</a> content attribute. | |||
There was a problem hiding this comment.
You'll need to declare what kind of nonce you're looking for. Probably something like <a element-attr for="link">, or the shortcut <{link/nonce}> (which will produce prettier output).
| @@ -667,6 +675,7 @@ | |||
| <dfn attribute for="HTMLLinkElement"><code>rel</code></dfn>, | |||
| <dfn attribute for="HTMLLinkElement"><code>rev</code></dfn>, | |||
| <dfn attribute for="HTMLLinkElement"><code>media</code></dfn>, | |||
| <dfn attribute for="HTMLLinkElement"><code>nonce</code></dfn>, | |||
| @@ -334,6 +334,7 @@ | |||
| <dd><{link/rel}> — Relationship of this document (or subsection/topic) to the destination resource</dd> | |||
| <dd><{link/rev}> — <a>Reverse link</a> relationship of the destination resource to this document (or subsection/topic)</dd> | |||
| <dd><code>media</code> — Applicable media</dd> | |||
| <dd><code>nonce</code> — Cryptographic nonce used in Content Security Policy checks [[CSP3]]</dd> | |||
| @@ -542,7 +542,7 @@ | |||
| </tr> | |||
| <tr> | |||
| <th><code>nonce</code></th> | |||
| <td><{script}>; <{style}></td> | |||
| <td><{link}>; <{script}>; <{style}></td> | |||
There was a problem hiding this comment.
There are two indices in the WHATWG spec: one for attribute -> element, and one for the inverse. I don't know if the W3C doc follows that model.
There was a problem hiding this comment.
yup, found it and added, thanks
mikewest
reviewed
Sep 30, 2016
| @@ -334,6 +334,7 @@ | |||
| <dd><{link/rel}> — Relationship of this document (or subsection/topic) to the destination resource</dd> | |||
| <dd><{link/rev}> — <a>Reverse link</a> relationship of the destination resource to this document (or subsection/topic)</dd> | |||
| <dd><code>media</code> — Applicable media</dd> | |||
| <dd><code>nonce</code> — Cryptographic nonce used in Content Security Policy checks [[CSP3]]</dd> | |||
There was a problem hiding this comment.
Nit: The leading whitespace here still seems incorrect.
There was a problem hiding this comment.
It'll render the same... noted, thanks
|
Thanks. |
W3C-HTML-Bot
pushed a commit
that referenced
this pull request
Sep 30, 2016
arronei
pushed a commit
to arronei/html
that referenced
this pull request
Apr 17, 2017
* ported nonce on link refer to whatwg/html#1820 * fixed link/nonce dfn * code error forgot to close <a> * updated nonce after mw review w3c#604 (review)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports nonce on link to w3c html as per #599
2 issues with build:
LINK ERROR: No 'dfn' refs found for 'nonce'.
LINK ERROR: No 'idl-name' refs found for 'boolean'.
can't work out why these are occuring...
please review @adanilo, @travisleithead @arronei