This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #1456 Make author encouragement stronger, note current reality.
(note the new WD)
Marked as non substantive for IPR from ash-nazg. |
Looks good to me but for the change.include conflict. |
siusin
reviewed
Jul 27, 2018
sections/semantics-links.include
Outdated
as it provides several advantages, in particular to give users control over their privacy. | ||
|
||
* Because the final target URL is in the link, | ||
the user has more certainty about where they will navigate to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bikeshed complains about the line-break here...
sections/semantics-links.include
Outdated
* Because the final target URL is in the link, | ||
the user has more certainty about where they will navigate to. | ||
* User agents, or extensions, could reliably inform the user about tracking notifications, | ||
and allow the user to disable them on a case-by-case basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed them.
Keeping bikeshed happy. Because tools are made to serve people, right> ;)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1456
Make the author encouragement a formal should (effectively a substantive change but no requirement on browser implementation)
Clarify the potential benefits and the current reality.