clean up img/decoding #1411
clean up img/decoding #1411
Conversation
fix #1388 * Note it is at risk (but it is likely to be OK) * Add it to `img` attributes list * Add it to attributes index
| The <dfn element-attr for="img"><code>referrerpolicy</code></dfn> attribute is a <a>referrer policy attribute</a>. Its purpose is to | ||
| set the <a>referrer policy</a> used when <a>fetching</a> the image. [[!REFERRERPOLICY]] | ||
| The <dfn element-attr for="img"><code>decoding</code></dfn> attribute is an enumerated attribute. | ||
| It is an [=image decoding hint=], to reqeust synchronous asynchronous image loading. |
There was a problem hiding this comment.
I think there’s an "or" missing between "synchronous asynchronous".
(And does the comma have a function in the same sentence?)
There was a problem hiding this comment.
"or": yep. +typo in "request", and the comma is ok but unnecessary.
all fixed - thank you
| set the <a>referrer policy</a> used when <a>fetching</a> the image. [[!REFERRERPOLICY]] | ||
| The <dfn element-attr for="img"><code>decoding</code></dfn> attribute is an enumerated attribute. | ||
| It is an [=image decoding hint=] to request synchronous or asynchronous image loading. | ||
| Valid values are "<code>async</code>", "<code>async</code>", and "<code>auto</code>". |
There was a problem hiding this comment.
'are "<code>async</code>", "<code>async</code>", and' is typo.
There was a problem hiding this comment.
Oops, sorry, didn't refresh the page before merging... will submit another commit to fix this.
Thanks for the review @mtrootyy .
|
@chaals Why is this at risk? Safari and Chrome implement it. |
To be pedantic, it's potentially at risk. Because i was being super-cautious - and as noted, I figured it was likely OK. In painful detail, the tests I was looking at only actually covered the IDL attribute, not useful behaviour, and the Chromium info I dug up to start suggested implementation was still in progress. |
fix #1388
imgattributes list