This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Remove onshow #1278
Merged
Remove onshow #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(I think I'm right about this...) The `onshow` event handler was part of `contextmenu` - which was never implemented. See: * #589 * whatwg/html#2860 Re #1215
chaals
approved these changes
Mar 8, 2018
| @@ -2047,7 +2047,7 @@ | |||
| 1. If this {{Document}} object's <a>active sandboxing flag set</a> has its | |||
| <a>sandboxed <code>document.domain</code> browsing context flag</a> set, then throw a | |||
| "{{SecurityError}}" {{DOMException}}. | |||
| 1. Let <var>effectiveDomain</var> be this <code>Document</code>'s <a>origin</a>'s | |||
| 1. Let <var>effectiveDomain</var> be this {{Document}}'s [=concept/origin=]'s | |||
There was a problem hiding this comment.
This is an unrelated linking fix, no?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I think I'm right about this...)
The
onshowevent handler was part ofcontextmenu- which was never implemented.See:
Re #1215