This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 551
Fix Bikeshed Warnings #1218
Merged
Merged
Fix Bikeshed Warnings #1218
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
cddb992
Fix warning - not a var
edent d1142f6
Ignore unique <var>s
edent c650468
Fix Build Error - valid MIME type with no parameters
edent 80beff2
Fix build errors - Document initialization
edent f7aeb10
Fix build errors - browsing context
edent ab088cf
Fix build warnings - external reference to shipped
edent 3f69714
Fix build error - changes
edent 19639b8
Sync with Chaals' changes
edent 191b2cd
Fix build warnings - effective domain
edent bd2f439
Fix build warnings - rendering
edent 011610d
Fix broken rendering
edent 83f34f1
Fix build errors - webappapis
edent 2fecb8a
Fix build errors - webappapis
edent e05baa8
Fix build errors - optional-tags
edent 0c20c2d
Fix build errors - Script Record
edent 0a68b4b
Removing `style/nonce`
edent 1812625
Fix build errors - white space
edent 6277a62
Fix build errors - nonce
edent 519387b
Fix build errors - remove link/nonce
edent c12b1d8
Fix scope
edent 2dd00f4
Fix for document init
edent b458bc9
Rephrase
edent d899a71
Parser metadata
edent 7faa967
Merge branch 'master' into 1215-warnings-edent
chaals File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't nonce defined just below? Why the extra
dfn
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I don't add that dfn, I get
LINK ERROR: No 'dfn' refs found for 'nonce'.<a data-link-type="dfn" data-lt="nonce">nonce</a>
This may be down to me not fully understanding bikeshed cross references.