Skip to content

Commit

Permalink
Colspan rowspan update (#342)
Browse files Browse the repository at this point in the history 
* test and spec updates

remove MAY tests for aria-rowspan/colspan
comment out MAY portions of these attribute rules

* rowspan/colspan implementation updates

update report to reference that there are only two tests to pass for the aria-rowspan/colspan entries.
wording update for ibm’s stance on redundant role declarations
  • Loading branch information
@scottaohara
scottaohara authored Aug 23, 2021
1 parent c9343ad commit 045e1e7
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 49 deletions.
8 changes: 8 additions & 0 deletions index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3107,9 +3107,13 @@ <h3 id="docconformance-attr">
Use the `colspan` attribute on any element that is
allowed the `colspan` attribute in HTML.
</p>
<!--
Removing per issue #338
Revised rules to be re-added
<p>
Authors MAY use the `aria-colspan` attribute on any element that is allowed the `colspan` attribute in HTML, or any element with a WAI-ARIA role which allows the <a data-cite="wai-aria-1.1#aria-colspan">`aria-colspan` attribute</a>.
</p>
-->
<p>
Authors SHOULD NOT use the `aria-colspan` attribute on any element which also has a `colspan` attribute.
</p>
Expand All @@ -3131,9 +3135,13 @@ <h3 id="docconformance-attr">
Use the `rowspan` attribute on any element that is
allowed the `rowspan` attribute in HTML.
</p>
<!--
Removing per issue #338
Revised rules to be re-added
<p>
Authors MAY use the `aria-rowspan` attribute on any element that is allowed the `rowspan` attribute in HTML, or any element with a WAI-ARIA role which allows the <a data-cite="wai-aria-1.1#aria-rowspan">`aria-rowspan` attribute</a>.
</p>
-->
<p>
Authors SHOULD NOT use the `aria-rowspan` attribute on any element which also has a `rowspan` attribute.
</p>
Expand Down
20 changes: 10 additions & 10 deletions results/implementation-results.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

<body>
<h1>Implementation Report</h1>
<p>Last updated 28 June 2021</p>
<p>Last updated 19 August 2021</p>
<p>
Status of checks against the <a href="https://www.w3.org/TR/html-aria/">ARIA in HTML</a> rules in the following implementations:
</p>
Expand All @@ -56,7 +56,7 @@ <h2>Conformance Checker Rule Implementations</h2>

<p>As of 06-26-2021 all features have been verified to have at least two implementations. There are no features at risk.</p>

<p><b>Note:</b> IBM has decided they will not return errors/warnings when explicit roles are specified on elements with those implicit roles.</p>
<p><b>Note:</b> IBM presently does not return errors/warnings when explicit roles are specified on elements which natively expose that role implicitly.</p>

<table class="simple">
<caption>
Expand Down Expand Up @@ -3696,20 +3696,20 @@ <h2>Conformance Checker Rule Implementations</h2>
Use the <code>colspan</code> attribute on any element that is
allowed the <code>colspan</code> attribute in HTML.
</p>
<p>
<!-- <p>
Authors <em class="rfc2119">MAY</em> use the <code>aria-colspan</code> attribute on any element that is allowed the <code>colspan</code> attribute in HTML, or any element with a WAI-<abbr title="Accessible Rich Internet Applications">ARIA</abbr> role which allows the <code>aria-colspan</code> attribute.
</p>
</p> -->
<p>
Authors <em class="rfc2119">SHOULD NOT</em> use the <code>aria-colspan</code> attribute on any element which also has a <code>colspan</code> attribute.
</p>
<p>
Authors <em class="rfc2119">MUST NOT</em> use <code>aria-colspan</code> on any element which also has a <code>colspan</code> attribute, and the values of each attribute do not match.
</p>
</td>
<td><a href="https://w3c.github.io/html-aria/tests/colspan-test.html">colspan (3 tests)</a></td>
<td><a href="https://w3c.github.io/html-aria/tests/colspan-test.html">colspan (2 tests)</a></td>
<td><strong class=yes>yes</strong><br>- <a href="https://github.com/validator/validator/issues/1107">issue 1107</a></td>
<td><strong class=yes>yes</strong><br> - <a href="https://github.com/ThePacielloGroup/WAI-ARIA-Usage/issues/14">issue 14</a></td>
<td>partial implementation: <br>passes test 1 (of 3)<br>- <a href="https://github.com/IBMa/equal-access/issues/354">issue 354</a></td>
<td>Not yet implemented: <br>- <a href="https://github.com/IBMa/equal-access/issues/354">issue 354</a></td>
</tr>
<tr id="att-rowspan" tabindex="-1">
<th>
Expand All @@ -3724,20 +3724,20 @@ <h2>Conformance Checker Rule Implementations</h2>
Use the <code>rowspan</code> attribute on any element that is
allowed the <code>rowspan</code> attribute in HTML.
</p>
<p>
<!-- <p>
Authors <em class="rfc2119">MAY</em> use the <code>aria-rowspan</code> attribute on any element that is allowed the <code>rowspan</code> attribute in HTML, or any element with a WAI-<abbr title="Accessible Rich Internet Applications">ARIA</abbr> role which allows the <code>aria-rowspan</code> attribute.
</p>
</p> -->
<p>
Authors <em class="rfc2119">SHOULD NOT</em> use the <code>aria-rowspan</code> attribute on any element which also has a <code>rowspan</code> attribute.
</p>
<p>
Authors <em class="rfc2119">MUST NOT</em> use <code>aria-rowspan</code> on any element which also has a <code>rowspan</code> attribute, and the values of each attribute do not match.
</p>
</td>
<td><a href="https://w3c.github.io/html-aria/tests/rowspan-test.html">rowspan (3 tests)</a></td>
<td><a href="https://w3c.github.io/html-aria/tests/rowspan-test.html">rowspan (2 tests)</a></td>
<td><strong class=yes>yes</strong><br>- <a href="https://github.com/validator/validator/issues/1107">issue 1107</a></td>
<td><strong class=yes>yes</strong><br> - <a href="https://github.com/ThePacielloGroup/WAI-ARIA-Usage/issues/15">issue 15</a></td>
<td>partial implementation: <br>passes test 1 (of 3)<br>- <a href="https://github.com/IBMa/equal-access/issues/354">issue 354</a></td>
<td>Not yet implemented: <br>- <a href="https://github.com/IBMa/equal-access/issues/354">issue 354</a></td>
</tr>
</tbody>
</table>
Expand Down
26 changes: 6 additions & 20 deletions tests/colspan-test.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

<header>
<h1>ARIA in HTML - test cases for <code>aria-colspan</code></h1>
<p>last updated 27 February 2021</p>
<p>last updated 18 August 2021</p>
<p>
<a href="https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements"><code>colspan</code></a> is allowed on <code>td</code> and <code>th</code> elements
</p>
Expand All @@ -57,24 +57,7 @@ <h2>Tests:</h2>
<div class="flex">
<div class="widgetDemo">
<h3>Test 1</h3>
<p>Authors MAY use the <code>aria-colspan</code> attribute on any element that is allowed the <code>colspan</code> attribute in HTML, or any element with a WAI-ARIA role which allows the <code>aria-colspan</code> attribute. </p>

<p>The first <code>th</code> and <code>td</code> each have an <code>aria-colspan="1"</code></p>

<div class="testcase">
<table>
<thead>
<tr><th aria-colspan="1">header 1</th><th>header 2</th></tr>
</thead>
<tr>
<td aria-colspan="1">Cell 1</td>
<td>Cell 2</td>
</tr>
</table>
</div>

<p><strong>Expected result:</strong>
<br> no warning/error</p>
Edit: removed test.
</div>

<div class="widgetDemo">
Expand All @@ -86,7 +69,10 @@ <h3>Test 2</h3>
<div class="testcase">
<table>
<thead>
<tr><th aria-colspan="1" colspan="1">header 1</th><th>header 2</th></tr>
<tr>
<th aria-colspan="1" colspan="1">header 1</th>
<th>header 2</th>
</tr>
</thead>
<tr>
<td aria-colspan="1" colspan="1">Cell 1</td>
Expand Down
21 changes: 2 additions & 19 deletions tests/rowspan-test.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

<header>
<h1>ARIA in HTML - test cases for <code>aria-rowspan</code></h1>
<p>last updated 27 February 2021</p>
<p>last updated 18 August 2021</p>
<p>
<a href="https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements"><code>rowspan</code></a> is allowed on <code>td</code> and <code>th</code> elements
</p>
Expand All @@ -57,24 +57,7 @@ <h2>Tests:</h2>
<div class="flex">
<div class="widgetDemo">
<h3>Test 1</h3>
<p>Authors MAY use the <code>aria-rowspan</code> attribute on any element that is allowed the <code>rowspan</code> attribute in HTML, or any element with a WAI-ARIA role which allows the <code>aria-rowspan</code> attribute. </p>

<p>The first <code>th</code> and <code>td</code> each have an <code>aria-rowspan="1"</code></p>

<div class="testcase">
<table>
<thead>
<tr><th aria-rowspan="1">header 1</th><th>header 2</th></tr>
</thead>
<tr>
<td aria-rowspan="1">Cell 1</td>
<td>Cell 2</td>
</tr>
</table>
</div>

<p><strong>Expected result:</strong>
<br> no warning/error</p>
Edit: removed test.
</div>

<div class="widgetDemo">
Expand Down

0 comments on commit 045e1e7

Please sign in to comment.