Remove references to "sectioning root" #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookiecrook
approved these changes
Jan 30, 2023
stevefaulkner
approved these changes
Jan 30, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 31, 2023
Previous to this CL, <aside> was always mapped to a landmark role. Now, <aside> to landmark role (role=complementary) if: 1) Scoped to main or body elements, or 2) Given accessible name if scoped to sectioning content elements Additionally, the "sectioning root" concept was removed from html, therefore <header> and <footer> will only be mapped to a non landmark role if inside a sectioning content element (main, aside, navigation, section, article). See CORE-AAM update: w3c/html-aam#456 Finally, the mapping originally only respected sectioning content elements according to their html tag, but now they respect the equivalent ARIA roles as well. Fixed: 1286298 Change-Id: Iea9a4ce6c7480bbe73896d6bb53b025153215a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508314 Reviewed-by: David Tseng <[email protected]> Commit-Queue: Valerie Young <[email protected]> Cr-Commit-Position: refs/heads/main@{#1099511}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 1, 2023
This is a reland of commit 2f5b28a Reason for revert: broke accessibility tests on Fuchsia https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-arm64-rel/3640/overview Original change's description: > Update <aside>, <header>, <footer> HTML-AAM mapping > > Previous to this CL, <aside> was always mapped to a landmark role. > Now, <aside> to landmark role (role=complementary) if: > > 1) Scoped to main or body elements, or > 2) Given accessible name if scoped to sectioning content elements > > Additionally, the "sectioning root" concept was removed from html, > therefore <header> and <footer> will only be mapped to a non > landmark role if inside a sectioning content element (main, > aside, navigation, section, article). > See CORE-AAM update: w3c/html-aam#456 > > Finally, the mapping originally only respected sectioning content > elements according to their html tag, but now they respect the > equivalent ARIA roles as well. > > Fixed: 1286298 > Change-Id: Iea9a4ce6c7480bbe73896d6bb53b025153215a14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508314 > Reviewed-by: David Tseng <[email protected]> > Commit-Queue: Valerie Young <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1099511} Change-Id: I038a8e9a27ba53bf8075b9c92a4fb53149850f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4213811 Reviewed-by: David Tseng <[email protected]> Commit-Queue: Valerie Young <[email protected]> Cr-Commit-Position: refs/heads/main@{#1100028}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sectioning root was removed from HTML here: whatwg/html#7829
So this PR updates CORE-AAM to match the authors guidance here: https://w3c.github.io/html-aria/#el-header
And we separately discussed that the "sectioning root" check was unnecessary here: #375 (comment)
This doesn't close the issue #375 because scoped is still not defined.
Implementation
Preview | Diff