-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if mapped initial commit #226
Conversation
* adds bullet to element role mappings * adds TODO add if mapped for ia2/uia * adds if mapped conditional for ATK mappings * minor cleanups
Initial draft, please take a look if you can @joanmarie @carmacleod @stevefaulkner to make sure i'm on the right track with this. More work needs to happen here, but I wanted to at least get the verbage in for ATK from @joanmarie. Needs to add ia2/uia for other span-like elements and need to update the wording for elements like |
Hi, @scottaohara ! That said, I think it's on the right track from what I could see. |
@marcoscaceres might the preview/diff be an issue with the custom script that converts the giant table into individual element disclosure widgets? just wonder if there might be a way to fix that / at the very least look into just exposing the full table in this view. |
* move “if mapped” prior to the role information. * `b` AX update to “if mapped”. Otherwise only the AXStaticText subtree is exposed. * update ATK and AX mappings for `data` if mapped. * update introduction of `div` mappings to “if mapped” * `strong` AX update to “if mapped”. Otherwise only the AXStaticText subtree is exposed.
* update `i` to “if mapped” * update `s` to “if mapped” * update `span` to “if mapped” note: reverified that `var`, `kbd`, `samp`, `code` all map to `AXGroup` without assistance from an attribute like `aria-label` or `tabindex` to promote them as an accessible object.
note that only if mapped
note that AXGroup only if mapped
<td class="aria">No corresponding role</td> | ||
<td class="ia2"> | ||
<div class="general"> | ||
If mapped: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the MSAA or UIA columns for u
need the "If mapped: ... Otherwise".
I think they should be similar wording/formatting to the MSAA and UIA columns for s
?
Can I help with this? I can open a new issue for my last review comment (about u element) if that's holding things up. |
Hi @carmacleod No your comment wasn't holding things up. That was just a part of the spec I hadn't finished updating yet. It's more that as time has passed, I've become unsure that this is the direction this should be taking. Especially with how things have progressed with ARIA, and many of these elements should have a mapping of |
Ah, of course. Thanks, @scottaohara |
closing (but not deleting) this pull request as mappings to |
Work to be done:
div
& any other 'block' elements that should be updated to matchCloses #151
The following tasks have been completed:
Preview | Diff