Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if mapped initial commit #226

Closed
wants to merge 12 commits into from
Closed

if mapped initial commit #226

wants to merge 12 commits into from

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Jul 23, 2019

  • adds bullet to element role mappings
  • adds TODO add if mapped for ia2/uia
  • adds if mapped conditional for ATK mappings
  • minor cleanups

Work to be done:

  • similar wording and mapping expectations for IA2 / UIA (see todo comments)
  • revise wording for div & any other 'block' elements that should be updated to match

Closes #151

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.

Preview | Diff

* adds bullet to element role mappings
* adds TODO add if mapped for ia2/uia
* adds if mapped conditional for ATK mappings
* minor cleanups
@scottaohara
Copy link
Member Author

Initial draft, please take a look if you can @joanmarie @carmacleod @stevefaulkner to make sure i'm on the right track with this.

More work needs to happen here, but I wanted to at least get the verbage in for ATK from @joanmarie. Needs to add ia2/uia for other span-like elements and need to update the wording for elements like div that are "not mapped" / "if mapped"

@carmacleod
Copy link
Contributor

Hi, @scottaohara !
There's something funny with the Preview and Diff links - they don't include the table(s)... and it's a little bit rough to review the changes in the code because one needs to expand previous lines of code to figure out which element's table row each change is in... :)
Is it easy to fix the missing table in the Preview | Diff links?
Or do you have any other preview/diff links?

That said, I think it's on the right track from what I could see.

@scottaohara
Copy link
Member Author

@marcoscaceres might the preview/diff be an issue with the custom script that converts the giant table into individual element disclosure widgets?

just wonder if there might be a way to fix that / at the very least look into just exposing the full table in this view.

* move “if mapped” prior to the role information.
* `b` AX update to “if mapped”.  Otherwise only the AXStaticText subtree is exposed.
* update ATK and AX mappings for `data` if mapped.
* update introduction of `div` mappings to “if mapped”
* `strong` AX update to “if mapped”. Otherwise only the AXStaticText subtree is exposed.
* update `i` to “if mapped”
* update `s` to “if mapped”
* update `span` to “if mapped”

note: reverified that `var`, `kbd`, `samp`, `code` all map to `AXGroup` without assistance from an attribute like `aria-label` or `tabindex` to promote them as an accessible object.
note that only if mapped
note that AXGroup only if mapped
index.html Show resolved Hide resolved
<td class="aria">No corresponding role</td>
<td class="ia2">
<div class="general">
If mapped:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the MSAA or UIA columns for u need the "If mapped: ... Otherwise".
I think they should be similar wording/formatting to the MSAA and UIA columns for s?

@carmacleod
Copy link
Contributor

Can I help with this? I can open a new issue for my last review comment (about u element) if that's holding things up.

@scottaohara
Copy link
Member Author

Hi @carmacleod

No your comment wasn't holding things up. That was just a part of the spec I hadn't finished updating yet.

It's more that as time has passed, I've become unsure that this is the direction this should be taking. Especially with how things have progressed with ARIA, and many of these elements should have a mapping of role=generic.

@carmacleod
Copy link
Contributor

Ah, of course. Thanks, @scottaohara
I was asking because the issue regarding adding hgroup and slot to HTML AAM says #189 (comment).

@scottaohara
Copy link
Member Author

closing (but not deleting) this pull request as mappings to generic will make this unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need language/mapping for "not-mapped" elements which must be exposed due to attributes
3 participants