[geometry] Tighten up DOMMatrix's stringifier; throw for NaN/Infinity #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcorpan
force-pushed
the
zcorpan/dommatrix-tostring
branch
from
67fbb5f to
081bbe7
Compare
|
@domenic can you r? |
domenic
approved these changes
May 12, 2017
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
May 15, 2017
https://bugs.webkit.org/show_bug.cgi?id=172114 Reviewed by Simon Fraser. Source/WebCore: Align WebKitCSSMatrix stringifier with spec for DOMMatrix after: - w3c/fxtf-drafts#148 The following changes were made: - Use EcmaScript's ToString() to convert floating point values to string - Throw an invalid state error if the matrix contains non-finite values - Made WebKitCSSMatrix.toString enumerable as per [1]. [1] https://heycam.github.io/webidl/#es-stringifier Test: fast/css/matrix-stringifier.html * css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::toString): * css/WebKitCSSMatrix.h: * css/WebKitCSSMatrix.idl: * platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::containsOnlyFiniteValues): * platform/graphics/transforms/TransformationMatrix.h: LayoutTests: * fast/css/matrix-stringifier-expected.txt: Added. * fast/css/matrix-stringifier.html: Added. Add layout test coverage. * fast/dom/Window/custom-constructors-expected.txt: * fast/dom/Window/custom-constructors.html: Rebaseline existing test to reflect behavior change. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@216881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 16, 2017
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=172114 Reviewed by Simon Fraser. Source/WebCore: Align WebKitCSSMatrix stringifier with spec for DOMMatrix after: - w3c/fxtf-drafts#148 The following changes were made: - Use EcmaScript's ToString() to convert floating point values to string - Throw an invalid state error if the matrix contains non-finite values - Made WebKitCSSMatrix.toString enumerable as per [1]. [1] https://heycam.github.io/webidl/#es-stringifier Test: fast/css/matrix-stringifier.html * css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::toString): * css/WebKitCSSMatrix.h: * css/WebKitCSSMatrix.idl: * platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::containsOnlyFiniteValues): * platform/graphics/transforms/TransformationMatrix.h: LayoutTests: * fast/css/matrix-stringifier-expected.txt: Added. * fast/css/matrix-stringifier.html: Added. Add layout test coverage. * fast/dom/Window/custom-constructors-expected.txt: * fast/dom/Window/custom-constructors.html: Rebaseline existing test to reflect behavior change. Canonical link: https://commits.webkit.org/189058@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120.
Tests: web-platform-tests/wpt#5885