add Archive.createArchive(File) method #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofi86
added
the
type: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using EpubCheck in projects I often use the
Archiveclass to zip up an extracted epub folder.However, until now, there has been no possibility to specify the output path for the
Archive.createArchive()method.This sometimes results in overridden epub files when you extract an existing epub file in the same folder and then check the extracted folder with EpubCheck. Not good.
With this PR I add a new overloaded method
createArchive(File absoluteEpubFilePath)to change the output destination for the ZIP file.This affects no existing functionality so I'm sure, we can merge this for the next release, right @rdeltour ?