Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Saxon library to v11.4 #1448

Merged
merged 2 commits into from
Dec 9, 2022
Merged

feat: update Saxon library to v11.4 #1448

merged 2 commits into from
Dec 9, 2022

Conversation

rdeltour
Copy link
Member

@rdeltour rdeltour commented Dec 7, 2022

This commit updates the Saxon-HE dependency to version 11.4.

It refactors the Saxon-related code as follows:

  • update the function+registration code to the latest API changes
  • extract the Saxon schema reader factory (used by Jing) in its own class
  • the Saxon schema reader factory is made available to Jing via the SPI mechanism (declared in META-INF/services/com.thaiopensource.validate.SchemaReaderFactory). This notably allows Jing to find and use our factory for both Schematron and NVDL.
  • the Saxon schema reader factory no longer extends Jing's NewSaxonSchemaReaderFactory, which set the feature "XSLT_VERSION" to "2.0" and caused a Warning to be issued by Saxon 11.

Fix #1341

This commit updates the Saxon-HE dependency to version 11.4.

It refactors the Saxon-related code as follows:
- update the function+registration code to the latest API changes
- extract the Saxon schema reader factory (used by Jing) in its own class
- the Saxon schema reader factory is made available to Jing via the SPI
  mechanism (declared in
  `META-INF/services/com.thaiopensource.validate.SchemaReaderFactory`).
  This notably allows Jing to find and use our factory for both Schematron
  and NVDL.
- the Saxon schema reader factory no longer extends Jing's
  `NewSaxonSchemaReaderFactory`, which set the feature "XSLT_VERSION"
  to "2.0" and caused a Warning to be issued by Saxon 11.

Fix #1341
@rdeltour rdeltour added type: maintenance The issue is related to a meta task (build system, dependency update, etc) status: ready to merge The pull request is ready to be merged labels Dec 7, 2022
@rdeltour rdeltour added this to the v5.0.0 milestone Dec 7, 2022
@rdeltour rdeltour self-assigned this Dec 7, 2022
@rdeltour rdeltour modified the milestones: v5.0.0, v5.0.0-rc Dec 8, 2022
@rdeltour rdeltour changed the base branch from release/v5.0.0 to main December 8, 2022 13:52
@rdeltour rdeltour linked an issue Dec 8, 2022 that may be closed by this pull request
@rdeltour rdeltour merged commit ef2697e into main Dec 9, 2022
@rdeltour rdeltour deleted the feat/saxon-update branch December 9, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge The pull request is ready to be merged type: maintenance The issue is related to a meta task (build system, dependency update, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code to work with Saxon 11.3
1 participant