Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check the formal viewport meta tag syntax #1400

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

rdeltour
Copy link
Member

@rdeltour rdeltour commented Dec 2, 2022

  • HTM-047 is now reported for invalid viewport values
  • new HTM-056 is reported when a viewport value has no width or height
  • new HTM-057 is reported when a viewport width or height value is invalid (i.e. not a positive number or a well-known kewyword)

Also:

  • the isASCIIWhitespace static utility method is extraced to a public InfraUtil class in a new org.w3c.epubcheck.util.infra package
  • the viewport parser is tested as a standalone class in its own feature file. However, for easier lookup, this file is however located in the epub3/F-viewport-meta-tag directory, as if it was a functional test.
  • several additional functional tests are added to the epub3/08-layout directory, for viewport metadata checks.

Fixes #1214, fixes #1347

Note: this does not include the latest post-CR updates to the viewport requirements

- `HTM-047` is now reported for invalid `viewport` values
- new `HTM-056` is reported when a `viewport` value has no `width` or
  `height`
- new `HTM-057` is reported when a viewport width or height value is
  invalid (i.e. not a positive number or a well-known kewyword)

Also:

- the `isASCIIWhitespace` static utility method is extraced to a public
  `InfraUtil` class in a new `org.w3c.epubcheck.util.infra` package
- the viewport parser is tested as a standalone class in its own feature
  file. However, for easier lookup, this file is however located in the
  `epub3/F-viewport-meta-tag` directory, as if it was a functional test.
- several additional functional tests are added to the `epub3/08-layout`
  directory, for viewport metadata checks.

Fixes #1214, fixes #1347
Base automatically changed from test/rearrange-and-tag to release/v5.0.0 December 5, 2022 13:07
@rdeltour rdeltour merged commit 01a7758 into release/v5.0.0 Dec 5, 2022
@rdeltour rdeltour deleted the feat/meta-viewport-syntax branch December 5, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants