Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitmapChecker -> ImageInputStream not closed on image file validation. #689

Closed
jajessup opened this issue May 12, 2016 · 2 comments
Closed
Labels
type: bug The issue describes a bug
Milestone

Comments

@jajessup
Copy link

This results in image files being locked and not deleted after validation. We noticed this in the temp folder of Tomcat.

@tofi86 tofi86 closed this as completed in a563fc2 May 15, 2016
@tofi86
Copy link
Collaborator

tofi86 commented May 15, 2016

Should be fixed now. Thanks for reporting.

@tofi86 tofi86 added the type: bug The issue describes a bug label May 15, 2016
@tofi86 tofi86 self-assigned this May 15, 2016
@tofi86 tofi86 added this to the Next milestone May 15, 2016
@jajessup
Copy link
Author

Thanks Tobias, may you could look at this one also – it’s in the same file: It just needs to visibility change from private to public.

I say this because the object type is being returned from a “Public” function in the same file.

#686 BitmapChecker.ImageHeuristics looks like it should be a public class?

From: Tobias Fischer [mailto:[email protected]]
Sent: Sunday, May 15, 2016 4:55 PM
To: IDPF/epubcheck [email protected]
Cc: jajessup [email protected]; Author [email protected]
Subject: Re: [IDPF/epubcheck] BitmapChecker -> ImageInputStream not closed on image file validation. (#689)

Should be fixed now. Thanks for reporting.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #689 (comment) https://github.com/notifications/beacon/ARwjWi7Qgvpd9_w-XsiXVIMmFpe9xw9Rks5qB6Q0gaJpZM4Idfne.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue describes a bug
Projects
None yet
Development

No branches or pull requests

2 participants