Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data blocks are not scripted documents #1216

Closed
mattgarrish opened this issue Mar 14, 2021 · 0 comments
Closed

Data blocks are not scripted documents #1216

mattgarrish opened this issue Mar 14, 2021 · 0 comments
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Milestone
v5.0.0-beta

Comments

@mattgarrish
Copy link
Member

The 3.3 spec clarifies that if a script element contains a data block it is not a scripted content document.

There shouldn't be an error that the scripted property is missing on manifest items if a document only contains data blocks, and should be an error if it's marked as scripted and only contains data blocks.

See w3c/epub-specs#1352
@mattgarrish mattgarrish added the spec: EPUB 3.3 Impacting the support of EPUB 3.3 label Mar 14, 2021
@rdeltour rdeltour added the status: accepted Ready to be further processed label Nov 13, 2021
@rdeltour rdeltour added this to the v5.0.0-beta-1 milestone Nov 13, 2021
@rdeltour rdeltour added status: ready for implem The issue is ready to be implemented status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed status: ready for implem The issue is ready to be implemented labels Jan 23, 2022
rdeltour added a commit that referenced this issue Jul 8, 2022
@rdeltour
test: 'scripted' property is disallowed for data blocks
bf9bce1 
EPUBCheck already handled data block scripts properly
(see 05e5ac2)

But the test that reported an unnecessary `scripted` property did not
include a data block to be sure.

Fix #1216
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Sep 22, 2022
@rdeltour rdeltour mentioned this issue Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: completed Work completed, can be closed
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish