Skip to content

Commit

Permalink
test: do not use file names with illegal characters in tests
Browse files Browse the repository at this point in the history
File names with EPUB-illegal characters are also NTFS-invalid names,
so they can cause issues (cannot be easily checked out by git on Windows
or may cause runtime issues on NTFS).

This commit replaces the expanded EPUBs in invalid characters by tests
by packaged EPUBs.

Fix #1420.
  • Loading branch information
rdeltour committed Dec 6, 2022
1 parent d3e4e1f commit 2809c23
Show file tree
Hide file tree
Showing 14 changed files with 2 additions and 98 deletions.
Binary file not shown.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Binary file not shown.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Empty file.

This file was deleted.

4 changes: 2 additions & 2 deletions src/test/resources/epub3/04-ocf/ocf.feature
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ Feature: EPUB 3 — Open Container Format

@spec @xref:sec-container-filenames
Scenario: Report forbidden characters in file names
When checking EPUB 'ocf-filename-character-forbidden-error'
When checking EPUB 'ocf-filename-character-forbidden-error.epub'
Then error PKG-009 is reported
And no other errors or warnings are reported

@spec @xref:sec-container-filenames
Scenario: Report forbidden characters in file names even for non-publication resources
When checking EPUB 'ocf-filename-character-forbidden-non-publication-resource-error'
When checking EPUB 'ocf-filename-character-forbidden-non-publication-resource-error.epub'
Then error PKG-009 is reported
And no other errors or warnings are reported

Expand Down

0 comments on commit 2809c23

Please sign in to comment.