Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing editor's notes #1934

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Removing editor's notes #1934

merged 2 commits into from
Nov 23, 2021

Conversation

iherman
Copy link
Member

@iherman iherman commented Nov 23, 2021

Two editors' notes have been added in #1898. Those two notes have been turned into explicit issues (see #1932 and #1933), and this PR removes those two notes from the spec.

dauwhe
dauwhe requested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@dauwhe dauwhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a close div that should be removed, too?

mattgarrish
mattgarrish approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@mattgarrish mattgarrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just what @dauwhe said, otherwise fine by me.

@iherman
Copy link
Member Author

iherman commented Nov 23, 2021

I think there's a close div that should be removed, too?

Oops.... Thanks!

@iherman iherman merged commit 2834995 into main Nov 23, 2021
@mattgarrish mattgarrish deleted the removing-editors-notes branch November 26, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dauwhe dauwhe dauwhe requested changes

@mattgarrish mattgarrish mattgarrish approved these changes

@dlazin dlazin Awaiting requested review from dlazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iherman @mattgarrish @dauwhe