-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marked UTF-8 as the that SHOULD be used #1645
Conversation
The issue was discussed in a meeting on 2021-04-23 List of resolutions:
View the transcript1.1. CSS files encodingSee github issue #1628. See github pull request #1645. Dave Cramer: first, encoding of CSS files Ivan Herman: not sure how much books currently use UTF16, but epubcheck having to warn about this means that some changes will have to be made to epubcheck Matt Garrish: i'm not sure how much epubcheck even looks at CSS Brady Duga: are there enough positive benefits to go ahead with this? Dave Cramer: we're trying to work with i18n WG Brady Duga: is it deprecated in CSS? Dave Cramer: they say you SHOULD use UTF8 Brady Duga: i would say "you should use UTF8", but i'm not sure about deprecating UTF16 Ivan Herman: i suspect there are tools and scripts which simply do not work with UTF16 Brady Duga: i'd be surprised if there are a lot of tools out there that don't support both encodings Matt Garrish: we are trying to align with the web, and what the other specs are saying Dave Cramer: i understand the concerns with deprecation Matt Garrish: that puts us more or less back in the same place, there's going to be an epubcheck warning Dave Cramer: and then people also have to go look up the definition of "deprecated", so maybe not saying that is more straightforward Ivan Herman: for sake of argument, Rust for example, which is gaining popularity, only uses UTF8
Ivan Herman: but yes, let's change the PR
|
@mattgarrish can you check whether the change is fine with the WG resolution? @xfq following the WG resolution the text has now an extra "UTF-8 SHOULD be used". The reason that it is a SHOULD and not a MUST is due to our backward compatibility obligation. Are you o.k. merging this and, thereby, closing the original issue? |
Although I wonder if it would make sense to simplify the statements to:
We lose the "must" but maybe this is a more readable way of phrasing what we want? |
Yes, but that phrasing would allow the author to use UTF-1234... Ie, it is more readable, but relies on the knowledge that there are only these two encodings of UTF... |
I wouldn't think so. It's effectively you should use this one but may use the other. Binary choice. But if that's not clear enough we could make that specific with "No other encodings are allowed." on the end. It's the "should" that makes the current formulation seem awkward, as it clashes with the must. An alternative might be: "It MUST be encoded in either UTF-8 or UTF-16, with UTF-8 the RECOMMENDED encoding. |
Yes! That seems to be perfect. I have updated the document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
This is a PR implemented the proposed solution outlined in #1628 (comment) for issue #1628.
Merging this PR must be sanctioned by a WG resolution.
Fix #1628.
Preview | Diff