ReSpec update #530
Merged
ReSpec update #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also removes the custom JavaScript and updates the ReSpec config
tidoust
requested changes
Apr 19, 2024
There was a problem hiding this comment.
You dropped the IDs but did not replace the occurrences of <a href=#foo> in your last commit as far as I can tell, see for instance:
#530 (comment)
(same problem for a couple of other IDs)
tidoust
reviewed
Apr 19, 2024
tidoust
approved these changes
Apr 19, 2024
joeyparrish
approved these changes
Apr 19, 2024
marcoscaceres
approved these changes
Apr 22, 2024
gregwfreedman
approved these changes
Apr 26, 2024
|
Thank you all for your reviews and comments. I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519
Fixes #528.
As much as possible, I've made each change in a single commit, to aid review, but we may want to squash when merging.
As well as updating to the latest ReSpec template, this PR also removes the boilerplate parameter type tables, and constructor sections which aren't needed. Where the parameter descriptions contained useful information, I've moved this text elsewhere in the spec.
Preview | Diff