Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd links to moved files #262

Closed
wants to merge 1 commit into from
Closed

Readd links to moved files #262

wants to merge 1 commit into from

Conversation

johanneswilm
Copy link
Contributor

Closes #261

@johanneswilm johanneswilm requested a review from annevk June 2, 2020 10:08
@annevk
Copy link
Member

annevk commented Jun 2, 2020

Could you explain why this is preferable? It seems you end up with more clutter, not less. And the inactive/graduated organization seems to encourage further breakage of links down the line.

@johanneswilm
Copy link
Contributor Author

The new file structure was proposed by people from Microsoft, not me. I voiced my concerns at the time. This is me trying to reconcile the interests of the various parties involved and I know @gked is currently not available. I agree that there will be a little more clutter with this, but there will always be some of that given that we have used this repository for incubation.

@annevk
Copy link
Member

annevk commented Jun 2, 2020

I would prefer that we revert for now and then if there's a need for breaking URLs there's a slightly wider discussion that involves downstream dependencies.

@johanneswilm
Copy link
Contributor Author

johanneswilm commented Jun 2, 2020

Note though that reverting will also reintroduce most of these link files. I believe that a number of other changes have been introduced in the meantime, so we'll have to move the files back manually.

@annevk
Copy link
Member

annevk commented Jun 2, 2020

That seems fine to me.

@johanneswilm
Copy link
Contributor Author

One last question: Do we know if there are other files than execCommand.html that have links to them?

@annevk
Copy link
Member

annevk commented Jun 2, 2020

HTML only links execCommand.html at the moment. But that might not be the only place that links things.

@johanneswilm
Copy link
Contributor Author

Ok, given that our next call is on June 12th and that @gked is on long-term holiday, what do you people think we should do? I don't have much of an opinion about what the ideal repository structure is, but in the past it was mentioned a number of times that the directory structure that I had inherited from Benjamin Peters and maintained over the last few years was not good by various other browser people, which is why I agreed to the change proposed by the Microsoft people.

@marcoscaceres @LJWatson @frivoal @saschanaz @BoCupp-Microsoft

@saschanaz
Copy link
Member

Separating the main branch and the gh-pages branch might be a solution. That way we don't need to keep all those redirecting files in the main one.

@@ -0,0 +1,6 @@
<!doctype html>
<meta charset="utf-8">
<meta http-equiv="refresh" content="0; url=https://w3c.github.io/editing/docs/contentEditableDisabled.html">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest doing this instead for each of them:

Suggested change
<meta http-equiv="refresh" content="0; url=https://w3c.github.io/editing/docs/contentEditableDisabled.html">
<script>
let currentHash = window.location.hash;
let newLocation = "https://w3c.github.io/editing/docs/contentEditableDisabled.html" + currentHash;
window.location = newLocation;
</script>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanneswilm feel free to commit this suggestion... you will need to update the other files too.

@marcoscaceres
Copy link
Member

Separating the main branch and the gh-pages branch might be a solution. That way we don't need to keep all those redirecting files in the main one.

That sounds hard to keep in sync, to be honest. It also makes it hard for new contributors to know where to send stuff.

@johanneswilm, if the new structure works better for you and the task force, then I would merge this. However, I'd search for any downstream that might be pointing to the new location for the specs.

@johanneswilm
Copy link
Contributor Author

@annevk Would you be OK with a solution such as that outlined by @marcoscaceres above? If so, I think it sounds as that would be the thing we should do unless someone else is against it.

@saschanaz
Copy link
Member

That sounds hard to keep in sync, to be honest.

It should be automated with some GitHub Actions.

It also makes it hard for new contributors to know where to send stuff.

Not sure I follow this one, could you elaborate? I think a simple reverting will make things harder for new contributors as they will see more redundant placeholders.

@johanneswilm
Copy link
Contributor Author

@saschanaz would the gh-branches contain the same as master + links from old doc locations and nothing more?

@saschanaz
Copy link
Member

@saschanaz would the gh-branches contain the same as master + links from old doc locations and nothing more?

Yes, so that we can ignore redirection placeholders on the master branch.

@johanneswilm
Copy link
Contributor Author

if the new structure works better for you and the task force

This seems to be the case for those participating in the task force that have voiced an opinion about this so far. The new structure also works for me but I'd also be willing to move to some third structure if there was strong opinion about that in the taskforce.

As for whether to only add the links to the gh-pages branch and have a separate master branch or not, I can see the advantages/disadvantages both of you are mentioning.

Given that @gked is on holidays, I don't have much of an opinion, and the next call is in more than week, does that mean that this is up the the WG chairs to decide? I take it that it is rather urgent to resolve the issue of dead links in the HTML spec.

@annevk
Copy link
Member

annevk commented Jun 4, 2020

It seems they have been dead since March and nobody noticed so it can probably take a little longer.

@johanneswilm johanneswilm added the Agenda+ Agenda item to be inserted in the Editing TF meeting queue label Jun 9, 2020
@johanneswilm johanneswilm removed the Agenda+ Agenda item to be inserted in the Editing TF meeting queue label Jun 16, 2020
@johanneswilm
Copy link
Contributor Author

This has been replaced by #264

@travisleithead travisleithead deleted the readd-links branch October 11, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execCommand.html is a 404
4 participants