CR: check CR with specberus and check approvals with GH API

.jscs.json

@@ -31,7 +31,6 @@
   "disallowTrailingWhitespace": true,
   "maximumLineLength": 160,
   "requireBlocksOnNewline": 1,
-  "requireCamelCaseOrUpperCaseIdentifiers": true,
   "requireCapitalizedComments": true,
   "requireCapitalizedConstructors": true,
   "requireCommaBeforeLineBreak": true,

app.js

@@ -89,6 +89,7 @@ var processRequest = function (req, res, isTar) {
   var decision = req.body ? req.body.decision : null;
   var url = (!isTar && req.body) ? req.body.url : null;
   var token = (!isTar && req.body) ? req.body.token : null;
+  var editorial = Boolean(req.body && req.body.editorial && /^true$/i.test(req.body.editorial));
   var tar = (isTar) ? req.file : null;
   var user = req.user ? req.user : null;
   var dryRun = Boolean(req.body && req.body['dry-run'] && /^true$/i.test(req.body['dry-run']));
@@ -110,7 +111,8 @@ var processRequest = function (req, res, isTar) {
     requests[id]['version'] = meta.version;
     requests[id]['version-specberus'] = SpecberusWrapper.version;
     requests[id]['decision'] = decision;
-    var jobList = ['retrieve-resources', 'metadata', 'specberus', 'third-party-checker', 'publish', 'tr-install', 'update-tr-shortlink'];
+    requests[id]['editorial'] = editorial;
+    var jobList = ['retrieve-resources', 'metadata', 'specberus', 'transition-checker', 'third-party-checker', 'publish', 'tr-install', 'update-tr-shortlink'];
 
     if (isTar)
       jobList.splice(2, 0, 'user-checker');
@@ -132,6 +134,7 @@ var processRequest = function (req, res, isTar) {
       url,
       tar,
       token,
+      editorial,
       user,
       tempLocation,
       httpLocation,

config.js.example

@@ -28,3 +28,6 @@ global.LDAP_URL = "ldaps://localhost:636";
 global.LDAP_SEARCH_BASE = 'ou=user,dc=example,dc=org';
 // LDAP_BIND_DN must contain the placeholder {{username}}
 global.LDAP_BIND_DN = 'uid={{username}},ou=user,dc=example,dc=org';
+global.GH_TOKEN = '123foobar';
+global.GH_DIRECTOR_TEAM_ID = '2797096';
+global.GH_COMM_TEAM_ID = '2794457';

lib/orchestrator.js

@@ -14,6 +14,7 @@ var SpecberusWrapper = require('./specberus-wrapper');
 var ThirdPartyChecker = require('./third-party-resources-checker');
 var TokenChecker = require('./token-checker');
 var UserChecker = require('./user-checker');
+var TransitionChecker = require('./transition-checker');
 
 // Configuration file
 require('../config.js');
@@ -52,13 +53,15 @@ function updateTrShortlink(uri) {
 var Orchestrator = function (url,
                              tar,
                              token,
+                             isEditorial,
                              user,
                              tempLoc,
                              httpLoc,
                              resultLoc) {
   this.url = url;
   this.tar = tar;
   this.token = token;
+  this.isEditorial = isEditorial;
   this.user = user;
   this.tempLocation = tempLoc;
   this.httpLocation = httpLoc;
@@ -156,6 +159,9 @@ Orchestrator.prototype.runStep = function (step) {
           });
         }
 
+        if (obj.has('cfe'))
+          state = state.addToMetadata('cfe', obj.get('cfe'));
+
         return state;
       })
       .catch(function (err) {
@@ -325,6 +331,35 @@ Orchestrator.prototype.runSpecberus = function (httpLocation,
   });
 };
 
+Orchestrator.prototype.runTransitionChecker = function (profile, latestVersion, previousVersion, isEditorial, isUpdate) {
+  return new Map({
+    name: 'transition-checker',
+    promise: TransitionChecker.check(profile, latestVersion, previousVersion, isEditorial, isUpdate)
+      .then(function (report) {
+        if (report.errors.isEmpty()) {
+          return new Map({
+            status: 'ok',
+            history: 'The document passed the transition checker.',
+            cfe: report.requiresCfE
+          });
+        }
+        else {
+          return new Map({
+            status: 'failure',
+            errors: report.errors,
+            history: 'The document failed the transition checker.'
+          });
+        }
+      }).catch(function (error) {
+        return new Map({
+          status: 'error',
+          errors: List.of(error.toString()),
+          history: 'An error occurred while running the transition checker.'
+        });
+      })
+  });
+};
+
 Orchestrator.prototype.runTokenChecker = function (latestVersion, url, token) {
   return new Map({
     name: 'token-checker',
@@ -475,6 +510,13 @@ Orchestrator.prototype.next = function (state) {
                              state.get('metadata').get('profile'),
                              state.get('metadata').get('rectrack'));
   }
+  else if (state.hasJobStarted('transition-checker')) {
+    step = this.runTransitionChecker(state.get('metadata').get('profile'),
+                                     state.get('metadata').get('latestVersion'),
+                                     state.get('metadata').get('previousVersion'),
+                                     this.isEditorial,
+                                     state.get('metadata').get('updated'));
+  }
   else if (state.hasJobStarted('token-checker')) {
     step = this.runTokenChecker(
       state.get('metadata').get('latestVersion'),

lib/publisher.js

@@ -31,7 +31,6 @@ var Publisher = function (service) {
  */
 Publisher.prototype.publish = function (metadata) {
   if (!(metadata instanceof Map)) throw new TypeError('metadata must be a Map');
-
   return this.service.post({
     specversion: {
       status: metadata.get('profile'),
@@ -46,7 +45,11 @@ Publisher.prototype.publish = function (metadata) {
       rectrack: metadata.get('rectrack'),
       informative: metadata.get('informative'),
       editorDraft: metadata.get('editorDraft'),
-      processRules: metadata.get('processRules')
+      processRules: metadata.get('processRules'),
+      implementationReport: metadata.get('implementationReport'),
+      implementationFeedbackDue: new Moment(metadata.get('implementationFeedbackDue', 'YYYY-MM-DD')
+              .format('YYYY-MM-DD'),
+      cfe: metadata.get('cfe')
     }
   }).then(function (out) {
     var response = out.response;

lib/specberus-wrapper.js

@@ -30,8 +30,11 @@ SpecberusWrapper.validate = function (url, profile, isRecTrack) {
     else if (profile === 'WG-NOTE') {
       specberusProfile = require('specberus/lib/profiles/TR/WG-NOTE-Echidna');
     }
+    else if (profile === 'CR') {
+      specberusProfile = require('specberus/lib/profiles/TR/CR-Echidna');
+    }
     else {
-      return reject(new Error('Only WD and Notes are allowed!'));
+      return reject(new Error('Only WD, CR and Notes are allowed!'));
     }
 
     sink.on('end-all', function () {

lib/transition-checker.js

@@ -0,0 +1,85 @@
+'use strict';
+
+var List = require('immutable').List;
+var Octokat = require('octokat');
+
+/**
+ * @exports lib/transition-checker
+ */
+
+var TransitionChecker = {};
+
+/**
+ * @returns {Promise.<List.<String>>}
+ */
+
+TransitionChecker.check = function (profile, latestVersion, previousVersion, isEditorial, isUpdate) {
+  return new Promise(function (resolve, reject) {
+    var errors = new List();
+
+    if (profile === 'WD' || profile === 'WG-NOTE' || isUpdate) {
+      resolve({ errors: errors, requiresCfE: false });
+    }
+    else if (profile === 'CR') {
+      if (previousVersion.includes('/WD-') || (previousVersion.includes('/CR-') && !isEditorial)) {
+        var octo = new Octokat({
+          token: global.GH_TOKEN
+        });
+        var repo = octo.repos('w3c', 'transitions');
+
+        var shortname = latestVersion.match(new RegExp(/.*\/([^/]+)\/$/))[1];
+        var directorApproval = 'Transition approved.';
+        var commApproval = 'Draft transition approved.';
+        var directorApprovalFound = false;
+        var commApprovalFound = false;
+
+        repo.issues.fetch(
+          {
+            labels: 'Awaiting publication',
+            state: 'open',
+            per_page: 100 // TODO: get all the issues, not just the first 100
+          })
+        .then((content) => {
+          for (var issue of content.items) {
+            if (issue.title.endsWith(' ' + shortname)) {
+              repo.issues(issue.number).comments.fetch()
+              .then((comments) => {
+                for (var comment of comments.items) {
+                  if (comment.body.startsWith(directorApproval)) {
+                    // Director's approval
+                    octo.teams(global.GH_DIRECTOR_TEAM_ID).members(comment.user.login).fetch((err) => {
+                      if (!err) directorApprovalFound = true;
+                    });
+                  }
+                  else if (comment.body.startsWith(commApproval)) {
+                    // Comm's approval
+                    octo.teams(global.GH_COMM_TEAM_ID).members(comment.user.login).fetch((err) => {
+                      if (!err) commApprovalFound = true;
+                    });
+                  }
+                }
+                if (!directorApprovalFound) errors.push('Director\'s approval not found.');
+                if (!commApprovalFound) errors.push('Communication team\'s approval not found.');
+                return resolve({ errors: errors, requiresCfE: true });
+              });
+            }
+            else {
+              // Issue not found
+              return reject(new Error('Issue not found on the github repository w3c/transitions.'));
+            }
+          }
+        })
+        .catch(function (error) {
+          return reject(new Error('An error occured while looking for the transition issue: ' + error));
+        });
+      }
+      else if (previousVersion.includes('/CR-') && isEditorial) {
+        return resolve({ errors: errors, requiresCfE: false });
+      }
+    }
+    else
+      reject(new Error('Only WD, CR and Notes are allowed!'));
+  });
+};
+
+module.exports = TransitionChecker;

package.json

@@ -53,6 +53,7 @@
     "moment": "2.22.2",
     "multer": "1.3.0",
     "node-uuid": "1.4.8",
+    "octokat": "0.10.0",
     "passport": "0.4.0",
     "passport-http": "0.3",
     "promise": "8.0.1",