Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add did-kilt-2021 #95

Merged
merged 7 commits into from
Jun 3, 2021
Merged

feat: add did-kilt-2021 #95

merged 7 commits into from
Jun 3, 2021

Conversation

ntn-x2
Copy link
Contributor

@ntn-x2 ntn-x2 commented May 10, 2021 •
edited
Loading

Kilt DID method specification

Kilt DID method specification test according to the GitHub thread.

Fixes https://github.com/KILTprotocol/ticket/issues/1293

@msporny
Copy link
Member

msporny commented May 14, 2021 •
edited
Loading

ETA on this PR being done, @Diiaablo95 ? We'd like to merge soon, if possible.

@ntn-x2
Copy link
Contributor Author

ntn-x2 commented May 18, 2021

Hey @msporny, it is currently blocked by #99, which I opened a while ago. Do you perhaps have suggestions?

@msporny
Copy link
Member

msporny commented May 24, 2021 •
edited
Loading

@Diiaablo95 ... Just as a status update... I'm currently trying to get the other implementers to fix some of their broken tests before trying to debug your issue. Have you made any progress in the meantime?

@ntn-x2
Copy link
Contributor Author

ntn-x2 commented May 25, 2021

@msporny I had to focus on other tasks in the past week, so I did close to zero work for this one. Some more details about the problem are mentioned in #99. As a non-JS expert, that is as far as I could go without spending too much time on the problem (time that I did not have).

@ntn-x2 ntn-x2 marked this pull request as ready for review June 3, 2021 08:11
@ntn-x2 ntn-x2 requested review from msporny and OR13 as code owners June 3, 2021 08:11
@ntn-x2 ntn-x2 changed the title Kilt/kilt did feat: add did-kilt-2021 Jun 3, 2021
@msporny msporny merged commit 61b10b6 into w3c:main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny Awaiting requested review from msporny msporny is a code owner

@OR13 OR13 Awaiting requested review from OR13 OR13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntn-x2 @msporny