-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Updated" property section. #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍, agreed that it belongs in the Resolver metadata.
Why should Being optional, nobody is required to include it, but I can think of many scenarios where it would be useful, regardless of whether anyone is using it today, so I don't understand the motivation to remove it. |
Further, there must have been reasons that the property was added in the first place. It follows that all of these should be shown to no longer be relevant, before the property should be removed. "I don't think anyone is using it" does not seem sufficient, even if we cannot easily identify any such user. |
a827fc9
to
64b324c
Compare
... because the resolver response is information /about/ the DID Document, not the DID Document itself. Think of it like a DNS lookup... the DNS lookup response will give you information about the record you looked up, along with a bunch of metadata about the record:
The
It is useful, as metadata about the DID Document. Placing it directly in the DID Document itself opens up an attack vector where people might trust the information because it's there, which is absolutely the wrong thing to do (because the entity in control of the DID can set it to any value they want to).
It was to track information related to when the document was updated... but the place where that information belongs is in the resolver response (because that's harder to attack), not the document itself (which would confuse some developers and make them check the wrong thing).
The purpose for removing it is both 1) don't think anyone is using it, and 2) it's an attack vector. |
Your "DNS lookup" example is actually a "
-- or
-- might be more appropriate. Note that neither gives the sort of metadata you're talking about. The metadata in the
There are plenty of places where metadata such as As far as "attack vector" -- A useful test for someone looking at such documents might be to compare the internally held These are worthwhile things to talk about and consider in where and whether these properties belong. Lacking a way to usefully poll the ecosystem, "I don't think anyone is using this" continues to trouble me. |
(Discussion continued in separate issue, #65 ) |
Waiting on resolution to #65. |
Closing based on discussion at DID F2F meeting: https://www.w3.org/2019/did-wg/Meetings/Minutes/2020-01-29-did#section11 I'll open a new PR eventually to address this metadata issue. |
This PR removes the updated property from the DID Document as I don't think anyone is using the property, and it almost certainly belongs in a DID Resolver response rather than a DID Document.
Preview | Diff