Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charter next #122

Closed
wants to merge 5 commits into from
Closed

Charter next #122

wants to merge 5 commits into from

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Sep 26, 2022

No description provided.

anssiko and others added 4 commits September 26, 2022 14:44
Undated version to use for charter development purposes.
To Be Defined later in the chartering process.
@xfq
Copy link
Member

xfq commented Sep 27, 2022

I added Netlify to make it easier to review the rendered HTML of pull requests.

@anssiko
Copy link
Member Author

anssiko commented Sep 28, 2022

@xfq thanks, does Netlify provide diff similar to pr-preview? Netlify docs did not mention.

And while we’re here, can we rename the repo to das-charter without breaking links?

@xfq
Copy link
Member

xfq commented Sep 29, 2022

@xfq thanks, does Netlify provide diff similar to pr-preview? Netlify docs did not mention.

No. We can use PR Preview to provide a diff. Although it can also provide previews, it has been unstable recently and only supports previews of a single document in a repo.

@xfq
Copy link
Member

xfq commented Sep 29, 2022

And while we’re here, can we rename the repo to das-charter without breaking links?

I'll look into it.

@netlify
Copy link

netlify bot commented Sep 29, 2022

Deploy Preview for w3c-das-charter ready!

Name Link
🔨 Latest commit 075976d
🔍 Latest deploy log https://app.netlify.com/sites/w3c-das-charter/deploys/633552c686be2a0008502739
😎 Deploy Preview https://deploy-preview-122--w3c-das-charter.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@w3c w3c deleted a comment from netlify bot Sep 29, 2022
@anssiko
Copy link
Member Author

anssiko commented Sep 29, 2022

@xfq I notice you've renamed the repo, thanks! It looks like redirects do not work yet, e.g. #122 should take us here, but I get 404. You're probably working on this, so just FYI.

@xfq
Copy link
Member

xfq commented Oct 4, 2022

GitHub automatically redirect references to the issues/PRs from the old name to the new one, but not GitHub Pages, so I created a dap-charter repo after renaming the repo to redirect the rendered charter. But doing this will make redirects of issues/PRs not work.

I don't have a good solution at the moment, but in order to avoid this kind of problem in the future, one approach I think of is to use Netlify (https://w3c-das-charter.netlify.app/DASCharter-2021.html) (or Vercel etc.) instead of GitHub Pages (https://w3c.github.io/das-charter/DASCharter-2021.html) for the rendered HTML. Since Netlify is not strongly coupled to a GitHub repo, we can configure the redirects ourselves.

@anssiko
Copy link
Member Author

anssiko commented Oct 4, 2022

@xfq here’s an example of a solution that works without breaking any links: https://github.com/webscreens/webscreens.github.io/blob/master/window-placement/index.html

@xfq
Copy link
Member

xfq commented Oct 5, 2022

Great idea! Filed w3c/w3c.github.io#108

@anssiko
Copy link
Member Author

anssiko commented Dec 2, 2022

Superseded by #126

@anssiko anssiko closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants