[css-scroll-snap-2] Use present tense for snap event names #9697
Comments
1 task
|
The CSS Working Group just discussed
The full IRC log of that discussion<fantasai> flackr: was pointed out that "snapchanged" event felt inconsistent with other names which use present tense<fantasai> flackr: removing past tense, and adding 'scroll' in front of 'snap' <fantasai> flackr: the idea was to make them sort next to the scroll events <fantasai> flackr: proposal is snapchanged -> scrollsnapchange and snapchanging -> scrollsnapchanging <TabAtkins> No particular opinion, except I agree the tense change is good. <fantasai> flackr: I think the tense change is good, ambivalent about adding 'scroll' <fantasai> flackr: they do only apply to scroll containers <fantasai> flackr: so not unreasonable to say 'scroll' <TabAtkins> I don't think "scroll" is quite necessary, unlikely that "snap" will ever apply meaningfully to anything else <fantasai> Agree, but the one benefit is it aligns closer to the CSS properties <fantasai> which makes it easier for people to associate them <fantasai> RESOLVED: scrollsnapchanging and scrollsnapchange <TabAtkins> Yeah, that's fair. |
DavMila
added a commit
to DavMila/csswg-drafts
that referenced
this issue
May 7, 2024
This renames snapchanged to scrollsnapchange and snapchanging to scrollsnapchanging, per the CSSWG [resolution](w3c#9697 (comment))
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 14, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619
tabatkins
pushed a commit
that referenced
this issue
May 14, 2024
This renames snapchanged to scrollsnapchange and snapchanging to scrollsnapchanging, per the CSSWG [resolution](#9697 (comment))
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 15, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 21, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
May 21, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538748 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1303892}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 21, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538748 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1303892}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 21, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538748 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1303892}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 21, 2024
Per the CSS working group resolution[1], snapchanging should be renamed to scrollsnapchanging. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40286359, 338290502 Change-Id: If7d5c87a874a32f19f453a6b9ad3f10c167466eb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 21, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes the relevant file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: I60132f4fe22ed5d5d37902b7f1570f7e96aba401
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 22, 2024
Per the CSS working group resolution[1], snapchanging should be renamed to scrollsnapchanging. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40286359, 338290502 Change-Id: If7d5c87a874a32f19f453a6b9ad3f10c167466eb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 22, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes the relevant file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: I60132f4fe22ed5d5d37902b7f1570f7e96aba401
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 22, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes the relevant file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: I60132f4fe22ed5d5d37902b7f1570f7e96aba401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538749 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Cr-Commit-Position: refs/heads/main@{#1304613}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 22, 2024
Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes the relevant file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: I60132f4fe22ed5d5d37902b7f1570f7e96aba401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538749 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Cr-Commit-Position: refs/heads/main@{#1304613}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 23, 2024
Per the CSS working group resolution[1], snapchanging should be renamed to scrollsnapchanging. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40286359, 338290502 Change-Id: If7d5c87a874a32f19f453a6b9ad3f10c167466eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538788 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1305040}
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
May 23, 2024
Per the CSS working group resolution[1], snapchanging should be renamed to scrollsnapchanging. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40286359, 338290502 Change-Id: If7d5c87a874a32f19f453a6b9ad3f10c167466eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538788 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1305040}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
May 23, 2024
Per the CSS working group resolution[1], snapchanging should be renamed to scrollsnapchanging. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40286359, 338290502 Change-Id: If7d5c87a874a32f19f453a6b9ad3f10c167466eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538788 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1305040}
|
Fixed by #10288 |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
May 30, 2024
…o scrollsnapchange, a=testonly Automatic update from web-platform-tests [css-scroll-snap-2] Rename snapchanged to scrollsnapchange Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538748 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1303892} -- wpt-commits: c638700720a02d9b652f773735075fce95dca52a wpt-pr: 46256
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
May 30, 2024
…o scrollsnapchange, a=testonly Automatic update from web-platform-tests [css-scroll-snap-2] Rename snapchanged to scrollsnapchange Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes the relevant file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: I60132f4fe22ed5d5d37902b7f1570f7e96aba401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538749 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Cr-Commit-Position: refs/heads/main@{#1304613} -- wpt-commits: 99874d7f9d7c393cc0beae06bbc069bb011aa9e6 wpt-pr: 46412
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
May 30, 2024
…to scrollsnapchanging, a=testonly Automatic update from web-platform-tests [css-scroll-snap-2] Rename snapchanging to scrollsnapchanging Per the CSS working group resolution[1], snapchanging should be renamed to scrollsnapchanging. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40286359, 338290502 Change-Id: If7d5c87a874a32f19f453a6b9ad3f10c167466eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538788 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1305040} -- wpt-commits: 83278a9b8486f07fc6cf27d89f6b4dd292c66bc9 wpt-pr: 46411
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
May 31, 2024
…o scrollsnapchange, a=testonly Automatic update from web-platform-tests [css-scroll-snap-2] Rename snapchanged to scrollsnapchange Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: Ia1eab843be5dd53208b51030aa516294008d8619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538748 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1303892} -- wpt-commits: c638700720a02d9b652f773735075fce95dca52a wpt-pr: 46256
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
May 31, 2024
…o scrollsnapchange, a=testonly Automatic update from web-platform-tests [css-scroll-snap-2] Rename snapchanged to scrollsnapchange Per the CSS working group resolution[1], snapchanged should be renamed to scrollsnapchange. This patch changes the relevant file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40273052, 338290502 Change-Id: I60132f4fe22ed5d5d37902b7f1570f7e96aba401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538749 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Cr-Commit-Position: refs/heads/main@{#1304613} -- wpt-commits: 99874d7f9d7c393cc0beae06bbc069bb011aa9e6 wpt-pr: 46412
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
May 31, 2024
…to scrollsnapchanging, a=testonly Automatic update from web-platform-tests [css-scroll-snap-2] Rename snapchanging to scrollsnapchanging Per the CSS working group resolution[1], snapchanging should be renamed to scrollsnapchanging. This patch changes file contents. A follow-up patch will change file names and directory names. [1]w3c/csswg-drafts#9697 (comment) Bug: 40286359, 338290502 Change-Id: If7d5c87a874a32f19f453a6b9ad3f10c167466eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538788 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1305040} -- wpt-commits: 83278a9b8486f07fc6cf27d89f6b4dd292c66bc9 wpt-pr: 46411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It was pointed out here that "snapchanged" (introduced in the scroll-snap-2 spec) doesn't follow the convention of using present tense to name JavaScript events.
Additionally, zcorpan suggests using names that put the snap events closer, alphabetically, to the
scrollandscrollendevents.To riff off on that suggestion, I propose:
scrollsnapchanginginstead of snapchanging, andscrollsnapchangeinstead of snapchangedwhich reflect not just that snapping is happening but that there is a change in snap targets as is the intention of the events.
The text was updated successfully, but these errors were encountered: