-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-animations-2] Add animation-trigger for triggering animations when an element is in a timeline's range #8942
Comments
also ping @birtles |
I'm just curious about what the discussion was here. I know in the very very early days of the scroll-driven animations spec we have scroll triggers which would have been awesome--basically like declarative intersection observer so you could trigger transitions or even just static changes. The main problem was just that you couldn't easily implement them such that they run on the compositor. I think they were probably the same thing as
Fill modes are tricky. They don't compose very well and we had to introduce the whole effect replacing mechanism just to prevent them from leaking memory. At times we've talked about deprecating them if we could. They might be the right primitive here, but just as a knee-jerk reaction, I think it would be worth considering other options before we try to overload them for this. |
There was a specific section on this in the CSSWG wiki but can't find it now cause the wiki is down ): I should note that a sort of an
Yes, there was such issue (couldn't find it) but we agreed that "scroll-driven" is technically and conceptually different from "scroll-trigger". So we closed that one.
Understood, they may be completely orthogonal to this case, just trying to consider sensible defaults. |
Yehonatan and I discussed this IRL while both at CSS Day. Must say I like the general idea of using
Good remark by Brian on not overloading As for bikeshedding: I would name the function FWIW: an alternative idea I had in the back of my mind somewhere was to adjust |
Giving this more thought, using This can be interpreted as 2 possible options:
IMO option 1. is less common, and will only have a meaning for long/infinite animations, and it's probably much more interesting to pursue option 2 with both variations. Naming aside, syntax could possibly looks something like: For 2.a.: .element {
animation-play-state: trigger(in-view 50%, once);
} or for 2.b.: .element {
animation-play-state: trigger(in-view 50%);
} And possibly with .element {
animation-play-state: trigger(in-view 50% / 10% 0);
} Also assuming |
In the early days when we discussed this, we recognized that this was not complicated to enable for animations, but we were concerned about how developers could use this to start transitions as it seemed like a natural thing people would want to do. There was a proposal to have a media query style syntax in #4339. See also #7478. e.g. @scroll-trigger(>500) {
/* style rules to trigger animation or transition */
} The issue with this is that evaluating this change requires a global style recalculation and as such would be unlikely to be able to be started on the compositor. I'm happy to solve this for animations which if we set up up-front we could dynamically trigger from the compositor. We should think about whether there are any ways we could set this up for transitions as well. E.g. maybe for transitions we could do something similar to I don't think it's a good idea to re-use
My thinking around this is that it is somewhat similar to .element {
animation-trigger: trigger(view(), entry 100%) once;
} In general the property might look something like:
The initial value would match the current behavior that animations "trigger" once when they are defined. |
Transitions, unlike animations, can't use the trigger in a property/value since they are triggered by the cascade itself. Having excluded the option for having a trigger as a selector, I think the only option still being discussed now is using state queries for that in #6402. I think that direction may also prove useful for the more advanced use-case for animations, when you want to separate the triggering element from the animated element.
Yes, these 2 options sound option 2 I mentioned above. The main problem I see with introducing a new property and not extending
I'm not sure we need the a point on a timeline. The time-based one is simply a delay, right? And the scroll-based one may be confusing, because what you probably want is a simply intersection, no matter which direction or point on the view-timeline the element is at. E.g: what happens with I guess if we add something like
I really like this part! Kind of binds together all the use-cases (: |
My apologies, I missed that this was the behavior you proposed for it. I still worry this isn't well described by the paused
If you think of this as similar to animation-delay, the animation is just "running" the whole time but it's in the before phase until triggered (i.e. only producing an effect if you have
When given a document timeline yes. I was thinking in the long run you might pass it a point on a (yet to be defined) video timeline or other such time-based triggers which are not simple delays.
There are a few ways that a single point could be interpreted.
We could imply all of these options from the proposed It sounds like you're suggesting though that you might want an upper limit, such as trigger a particular animation anytime you scroll between 500px and 1000px (such that a particular element is intersecting the viewport). I think in order to avoid timing issues you'd probably want to trigger even if the user scrolled past the range without ever entering it just so that you'd be in a consistent state regardless of scroll speed. I'm a bit worried this could get into an arbitrarily complex syntax space for multiple triggers, repeating triggers etc, however maybe a range based trigger always plays forward when you enter the range and plays backwards when you leave it and if you don't want one of the directional trigger points it is conceptually infinite / the start or end of the range. |
Yes, it should hold the fill state until triggered and after finishing, so I guess in that sense it's not really the play-state according to the model, and rather a new thing that toggles phases, as you say.
Yep, that sounds good.
Hmm, yes, +1 on that.
Yeah, sort of, you helped realize what I actually wanted is a range in which the computed value is a boolean, rather than progress. So inside it it's true and false outside. And a single toggle-point can be simply from range start to infinity. And these cover well scroll/view/hover/time/etc.
I think that defines the initial direction.
We may probably want to add multiple triggers, but I'd be happy to solve the single case first (: |
@flackr there is a problem with For example take an element with Either way we get a visual jump. |
I think another way to tackle this is by imagining how this would be implemented today: You'd have 2 IntersectionObservers: one for triggering on entry ( So you end up with 2 ranges:
Then, it could become something along the line of: animation-trigger: view(block 15%) cover / view(block -10%) cover repeat; And the second range is optional of course, and has to be larger than the first range (I think that's possible to validate, right?). |
|
I think this is a separate use case here, where you can trigger-in on entry and trigger-out on exit. The initial use-case was to trigger-in and having an option to run the animation only once. |
@bramus, yes, |
@bramus, @flackr, would appreciate your thoughts on what's suggested so far. Perhaps we can wrap up something that can be presented on the agenda for TPAC? Currently what we have is the following:Syntax:
With It would be nice if we could squeeze in a solution for |
ping @mirisuzanne |
To clarify what I suggested earlier, I think it would be helpful to always have a range (i.e. start and end) for all cases. When the end of the range is not specified it could be some form of infinity / auto value so that most of the time developers would only need to specify a start point. Then, it becomes easier to rationalize all of the behaviors. The "trigger" occurs whenever a rendering update results in going from outside of the range to inside of the range or vice versa, and the behavior depends on the mode:
@ydaniv does having a trigger range not fix the discontinuity issue? |
@flackr I’m a bit confused about the proposed range. When I think of a Scroll-Trigger Animation, I think of a certain line that the elements needs to cross, not a range. Say I want to trigger an animation when scrolling past the 1000px scroll offset, would your range then be About the
|
Yes, of course. If you don't expect navigation to an anchor then you're fine with just the start.
Usually "entrance" animations are usually "from" animations, meaning, they animate to an implicit
It's just like scroll vs. view timelines again (: You can set s specific point on the scroll and that's a valid use-case. But usually you'll set a trigger using IntersectionObserver and wait for an intersection, which can better described by view timeline. And the nice extra is that this also fixes the awkwardness of transforms on the same element, that by ignoring them we can reason about the trigger point without worrying about the initial animation frame. |
I can imagine use-cases where we'd want to completely skip an animation when jumping over the range, for example if we have a long page with multiple scroll-triggered animations, and are landing over some sections via an Even more, I can imagine the cases for the “range” being very short, like half a screen high, meaning that we'd only want to trigger an animation when we're in the range, for example if we have some kind of “screen” where we'd want to play some animation when that screen is completely in the viewport. Scrolling from either top or bottom, we'd want to trigger the animation only when the screen is completely in the viewport. |
This can be achieved with what @flackr said above, without a range end the animation will be triggered above, not skipped though. But with
IIUC this should be covered using |
I think I understand now, you want a point before which you can safely restore the before state without it being visible to the user. E.g. to put it in concrete terms maybe the start trigger is on |
I made a crude polyfill of this at https://flackr.github.io/web-demos/scroll-triggered/scroll-triggered.js . I'm hoping this can be helpful in putting together concrete demos. Demo using it: https://flackr.github.io/web-demos/scroll-triggered/ |
Nice! Looking at the code, I see this: animation-trigger: view() alternate contain 0% contain 100%; I assume this would also work, because animation-trigger: view() alternate contain; Same with this below, which expands to animation-trigger: view() alternate entry 100%; Am I correct in this? |
Now that you mentioned it, and also looking back at what @flackr wrote above:
We don't have a way for ranges of view timelines to reference the full scroll timeline, and the default for end range is |
No, because contain 100% is not the same thing as the infinite behavior (anything after the start point) that the polyfill implements. If we want to support a single trigger point that is active for any position after it we need to have different behavior from the default animation range single value. |
The polyfill implements this by changing the "fill" behavior of the implicitly created animation. We could implement different behavior for scroll trigger as I do think a common case will be to want a single trigger point forever. As for ways to represent this, |
@ydaniv I addressed the exit case #8942 (comment) by parsing up to 4 range triggers. The syntax in the polyfill is currently: animation-trigger:
<single-animation-timeline>
<once | repeat | alternate>
<animation-trigger-range-start>
<animation-trigger-range-end>?
<animation-exit-range-start>?
<animation-exit-range-end>? If exit range is unspecified it uses the same as the trigger range. The exit range provides a different range outside of which will cancel / restart The repeat example in the demo makes use of this to avoid seeing the flash away: .repeat {
animation-trigger:
view() /* A view timeline on the element itself. */
repeat /* Triggers the animation every time the trigger range is entered */
contain 0% contain 100% /* Triggers the animation on entering the contain range. */
cover; /* Cancels and prepares to trigger again on leaving the cover range. */
} |
thanks @flackr! This looks good! There's yet another use-case I'd like to consider: switching We could name it something like |
Doesn't sound right to me. I don't think we have anything else that behaves this way (as in same property and value inflate differently depending on context) right?
I like the |
There's been a lot of discussion on this issue, can someone summarize where it's at? |
What @flackr suggested here is what’s currently suggested. The values Here’s a few tests I created using Rob’s polyfill. These should help you better understand what these values do:
(Note the page sometimes needs a refresh to work correctly. Also requires a browser that does scroll-driven animations): And here’s some practical demos:
My findings with doing these tests and building these demos are that:
|
Thanks @bramus!
Yes, there's a discontinuity point with
I agree the I also asked for adding another type like |
It's probably worth putting together a slide in from left, slide out to right example to explore how easily that is supported. I'm imagining it should look something like this: @keyframes slide-in-from-left {
0% { transform: translateX(-100vw); }
}
@keyframes slide-out-to-right {
100% { transform: translateX(100vw);
}
.target {
animation:
/* slide-in-from-left should be active producing -100vw initially */
slide-in-from-left 500ms backwards,
/* slide-out-right is active after it triggers keeping the element at 100vw. */
slide-out-to-right 500ms forwards;
animation-trigger:
/* Slide in at entry 100% (note [1], overlaps when slide-out is triggered). */
view() alternate entry 100%,
/* Slide out at exit 0%. */
view() alternate exit 0%;
} [1] Note, if you immediately scroll to a position after |
Also worth noting without a way to refer to the entire scroll range (#9367) it's awkward to make triggers before a certain scroll position. E.g. we've been assuming that a single named range does some internal magic to extend to the end of the scroll range, but if I want an animation that is triggered when you're scrolled less than contain 100%, I have to extend the range far enough to pass the start scroll, e.g. animation-trigger: view() alternate entry calc(0% - 1000vh) contain 100%; SImilarly, we may need a value to return to the author for the automatically extended end of the range, e.g. animation-trigger: view() alternate contain 0%; When inspecting the animation trigger it's end value is supposed to be the end of the scroll, not |
The CSS Working Group just discussed
The full IRC log of that discussion<fantasai> flackr: Common use case for scroll-based animations<fantasai> ... is to have a time-based animation that starts at a certain scroll position <fantasai> flackr: in this issue, proposing a property that controls the playback of a time-based animation based on the scroll position <fantasai> flackr: leveraging the fact that we can define positions in scroll position useing scroll timelines <fantasai> flackr: so using one timeline (Scroll timeline), control play state of another animation on another timeline (time) <fantasai> flackr: WE have a proposal that tries to capture the various use cases <YehonatanDaniv> q+ <fantasai> flackr: We have a new property, I'm calling 'animation-trigger' <fantasai> flackr: associated with corresponding animation entry <fantasai> flackr: second value is behavior, come back to that later <fantasai> flackr: then you specify 2 ranges: range in which you activate the animation, and range in which you de-activate the animation <fantasai> flackr: behavior has 3 values, one for one-shot animation <fantasai> flackr: it never runs again after you trigger <fantasai> flackr: alternate is plays when entering, and reverses when you enter exit range <fantasai> flackr: final is cancelled [missed] <bramus> Demos for each range, using a (quick) polyfill: https://github.com//issues/8942#issuecomment-1853045701 <fantasai> flackr: as I say this, I'm realizing that one-shot can be represented with exit range being the entire scroll range <fantasai> fantasai: that might be confusing though <fantasai> YehonatanDaniv: we started with view timeline, actually <fantasai> YehonatanDaniv: scroll is also an option because no limit <fantasai> YehonatanDaniv: ranges are against a view timeline of the element <Rossen_> ack YehonatanDaniv <fantasai> flackr: they're the ranges of the timeline that you specified, whichever you specified <Rossen_> ack dbaron <fantasai> dbaron: I felt I only sort-of followed the descriptions of 3 values <fantasai> dbaron: does one of those values letyou do something where as you scroll down, it plays forward, and if you scroll up it plays backwards? <fantasai> flackr: that's the 'alternate' value <bramus> q+ <fantasai> flackr: which reverses the value when you leave the range <fantasai> flackr: I have a demo <Rossen_> ack bramus <fantasai> bramus: I have a bunch of tests to demo the various behaviors <fantasai> bramus: also built some demos for more real-world use cases <fantasai> bramus: such as stick element that animates as stuff enters/leaves scrollport <fantasai> bramus: I could achieve everything I wanted with the options <fantasai> bramus: but not ergonomic, if you use 'once' you just need to specify where it triggers <fantasai> bramus: for alternate need t2, and for repeat you need all 4 <fantasai> bramus: depending on the second value might need 1-4 values <fantasai> bramus: a bit confusing <fantasai> fantasai: First comment, I think maybe consider some longhands <Rossen_> ack fantasai <fantasai> fantasai: second, maybe we want to draft this up so that it's a bit more clear what the proposal is <fantasai> YehonatanDaniv: Another keyword that was proposed for toggling play state of animation <fantasai> YehonatanDaniv: for animations that play indefinitely <fantasai> flackr: yes, one use cases not handled was if you want the animation to just pause outside the range and continue when you re-enter the range <fantasai> Rossen_: Do we have a proposed path forward? <fantasai> flackr: Let's write something up in spec-ese, and come back <fantasai> PROPOSED: Draft up this proposal into css-animations-2 <fantasai> come back to WG for review <fantasai> RESOLVED: Draft up this proposal into css-animations-2, come back to WG for review <fantasai> <br type="intersession"> |
In the above case I guess it would probably make more sense to use the behavior of
You could use a named timeline, or extend the
I'm not following you here, why don't we want to get back |
@flackr I think we have a small issue with the ranges syntax. Take a look at the following example: #target {
animation-trigger: repeat view() contain cover;
} In the above the But the intent could also be to resolve to Should we add a #target {
animation-trigger: repeat view() contain / cover;
} And if there's no range on the lefthand side it can be computed to |
Entry animations are pretty common on the web. Currently in order to trigger time-based animations when an element enters the viewport we have to use IntersectionObserver.
The problems with this:
IntersectionObserver
s taketransforms
into account, so that messes up the ability to properly know when an element is in viewport when animating from outside of it using transformsThe idea of using an
in-view
selector was dismissed, so another idea is perhaps to extend theanimation-play-state
property to support a sort of "trigger" values instead of onlyrunning
/paused
, and reuse the newanimation-range
values syntax to toggle between these states, which could look like:A good thing about ranges is that they already ignore transforms for SDA, so the same semantics could apply here and help solve this problem of transforms messing with initial position for triggering on viewport intersection.
While this condition evaluates to
false
the value computes topaused
, and when it'strue
it will change torunning
.Another requirement would be to be able to both toggle every time the computed value changes, and also have it set once. Perhaps this could be inferred from the
animation-fill-mode
, so thatboth
andbackwards
are used for those respectively. Or maybe use specific syntax for distinguishing between the two.cc @bramus @flackr
The text was updated successfully, but these errors were encountered: