Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-contain] Remove "at-risk" for style containment #6272

Closed
chrishtr opened this issue May 6, 2021 · 4 comments
Closed

[css-contain] Remove "at-risk" for style containment #6272

chrishtr opened this issue May 6, 2021 · 4 comments
Labels
Closed Accepted by CSSWG Resolution Testing Unnecessary Memory aid - issue doesn't require tests

Comments

@chrishtr
Copy link
Contributor

chrishtr commented May 6, 2021

Right now, the level 2 draft spec says this:

The following features are at-risk, and may be dropped during the CR period:

style containment and the contain: style value

I propose that we drop this text. The reason it exists:

  • @emilio was skeptical of the use cases for style containment
  • Concerns about interoperability of style containment implementations, and Chromium bugginess in its initial implementation
  • Desire to improve the spec for counters (which was one of the main use cases motivating style containment)
  • Desire to be able to ship layout and paint containment earlier in Firefox, without getting blocked on the above

Since then:

Therefore I propose we remove the spec text mentioned above.

@astearns
Copy link
Member

astearns commented May 6, 2021

I think one thing we should consider is removing contain: style for lack of its own compelling use case and create a new contain: query-target (or some such) as suggested in #6174 that would include the behaviors currently defined for style layout and size

@chrishtr
Copy link
Contributor Author

chrishtr commented May 6, 2021

for lack of its own compelling use case

I still think containing CSS counters is a compelling use case. Otherwise style recalc won't be contained.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-contain] Remove "at-risk" for style containment, and agreed to the following:

  • RESOLVED: Remove at-risk label for style containment
The full IRC log of that discussion <dael> Topic: [css-contain] Remove "at-risk" for style containment
<dael> github: https://github.com//issues/6272
<dael> chrishtr: I think there's a use case now which people agree is important. Have improved definition with respect to HTML.
<dael> chrishtr: Spec says HTML ordinals are impl via css counters.
<dael> chrishtr: I think we're in good shape to remove those lines
<dael> florian: I wouldn't be surprised if when another browser impl there's something we overlooked, but don't need label anymore.
<dael> chrishtr: Agreed
<chris> rrsagent, here
<RRSAgent> See https://www.w3.org/2021/05/12-css-irc#T16-19-47
<dael> florian: Have some amount of tests. Want to put it back on track
<dael> astearns: When last discussed I think one impl was against implementing?
<dael> chrishtr: Previously emilio but I think all issues have been addressed
<dael> emilio: I don't object. My concern with style containment is it wasn't clear it was useful and interacted with lists, but since lists are now in terms of counters...still style containment doesn't allow style system optimization but it is needed for use case described
<dael> astearns: Process-wise I would like to see a second impl started. once we put at-risk it's easy to leave until we're sure it's going to happen. I'm not absolutely sure, but it's low risk to take off if we have to put back on
<dael> astearns: Prop: Remove at-risk label for style containment
<dael> RESOLVED: Remove at-risk label for style containment

@frivoal
Copy link
Collaborator

frivoal commented May 12, 2021

closed by f0da302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by CSSWG Resolution Testing Unnecessary Memory aid - issue doesn't require tests
Projects
None yet
Development

No branches or pull requests

4 participants