Reflect worklets moving to HTML #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, another thing which would be great is if I got issue triage access to this repository, so that I could help close or move worklets-related issues. whatwg/html#6056 closes 5 open issues/PRs and I'd like to tackle several others in the near future. |
|
lgtm - Just let me know when you want this merge'd. |
|
Woohoo, ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1000. This does two things:
(CSS Animation Worklet and Web Audio do not seem to ever create AnimationWorkletGlobalScopes, or reference a Worklet's list of global scopes, so nothing changed there.)
Thoughts welcome on the best way to convert existing worklet spec URLs into redirects. What I did here is kind of a hack, by using a mostly-empty NOTE, because I don't know enough about your build/deploy process. Ideally there would be a server-side redirect on https://drafts.css-houdini.org/worklets/ to https://html.spec.whatwg.org/multipage/worklets.html; maybe @plinss can help with that. For making https://www.w3.org/TR/worklets-1/ redirect, I think @sideshowbarker might be able to help.
Ideal flow here: