Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-layout-api] Naming of LayoutFragment#inlineSize, blockSize. #748

Closed
bfgeek opened this issue Apr 7, 2018 · 5 comments
Closed

[css-layout-api] Naming of LayoutFragment#inlineSize, blockSize. #748

bfgeek opened this issue Apr 7, 2018 · 5 comments

Comments

@bfgeek
Copy link
Contributor

bfgeek commented Apr 7, 2018

From @travisleithead (Travis - I'm picking off some larger things we can discuss in a group from your feedback...)

LayoutFragment's inlineSize and blockSize might be renamed to reflect (as noted in the spec) that they are relative to the border-box, e.g., inlineBorderBoxSize and blockBorderBoxSize…

@travisleithead
Copy link
Member

Very kind of you... my plan is to distill all that initial feedback down into only a few issues to file on this repo.

I want to re-emphasis how well done this spec is so far... definitely ranks among the more interesting specs I've read in a long while. It also opens up super-cool new scenarios as well.

@dbaron
Copy link
Member

dbaron commented Apr 8, 2018

For what it's worth, I disagreed with @travisleithead on this one, because:

  • it seems too verbose
  • it's actually not just the sizes but also the positions that are for the border-box

That said, I'm not strongly opposed on the basis of verbosity, but I probably would want consistency for the positions.

@bfgeek
Copy link
Contributor Author

bfgeek commented Apr 9, 2018

Thanks @travisleithead , we are meeting today so was just pulling out some things we can discuss as a group. Most of your feedback I can go through and fix/answer inline.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Naming, and agreed to the following resolutions:

  • RESOLVED: No change on https://github.com/w3c/css-houdini-drafts/issues/748
The full IRC log of that discussion <dael> Topic: Naming
<dael> github: https://github.com//issues/748
<dael> iank_: One feedback from trevors at TAG found it not saying border-box confusing.
<dael> dbaron: Yeah.
<dael> dbaron: As someone that works on layout code I'm used to knowing you have to work with border-box and you don't type it. Travis was looking at it further away from layout and he found it confusing.
<dael> dbaron: I lean toward disagreeing, but if we change it should be sizes and positions
<dael> iank_: Agree.
<dael> iank_: Unless webdev are really confused I'd lead toward us being shorter here.
<dael> Rossen: If anyone goes to extent of understanding what layout fragment is I have a hard tim ebelieving that person would struggle.
<dael> plinss: It's just knowing the difference of border and content box. Then what about box sizes and what do you do. Looks like it's more clarity.
<dael> Rossen: Someone going through learning phases.
<dael> Rossen: Objections to no change?
<dael> RESOLVED: No change on https://github.com//issues/748

@bfgeek
Copy link
Contributor Author

bfgeek commented Jun 28, 2018

Closing as resolved for no change at the moment. Going to reach out to more webdevs as they are starting to play around with this to see if we need to change anything.

@bfgeek bfgeek closed this as completed Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants