Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add normative expectations and examples for computedrole #176

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented May 16, 2023

Closes #174
Closes w3c/aria#1887

Describe Change Here!
add normative expectations and examples for computedrole


Preview | Diff

@cookiecrook
Copy link
Contributor Author

cookiecrook commented May 16, 2023

Diff Preview is unintelligible, but this PR is a significant update to the new Computed Role section.

index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great thanks! see one suggestion

index.html Outdated Show resolved Hide resolved
@cookiecrook
Copy link
Contributor Author

cookiecrook commented May 16, 2023

this is great thanks! see one suggestion

I agree with your reasoning for keeping "accessibility parent."

Co-authored-by: Valerie Young <[email protected]>
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@spectranaut spectranaut merged commit 5d6012b into main Aug 17, 2023
github-actions bot added a commit that referenced this pull request Aug 17, 2023
SHA: 5d6012b
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cookiecrook cookiecrook deleted the computedrole-hostlang branch November 8, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants