Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the "tab" role have AXTabButton as its subrole? #106

Closed
joanmarie opened this issue Jan 25, 2022 · 4 comments · Fixed by #107
Closed

Should the "tab" role have AXTabButton as its subrole? #106

joanmarie opened this issue Jan 25, 2022 · 4 comments · Fixed by #107
Assignees
Labels
PR-not-in-stable ready-for-stable tests + two implementatoins

Comments

@joanmarie
Copy link
Contributor

If you examine Safari Technology Preview's browser tabs, they expose:

AXRole: AXRadioButton
AXSubrole: AXTabButton
AXRoleDescription: tab

This subrole is not stated in the Core-AAM. Also it is not implemented in WebKit for the ARIA tab role -- at least not in Safari Technology Preview.

@cookiecrook: Should the ARIA role have the same subrole as the native widget?

@cookiecrook cookiecrook self-assigned this Jan 27, 2022
@cookiecrook
Copy link
Contributor

I vaguely recall we wanted the native browser tabs mapped differently than web app tabs, but I will double-check. If that is correct, we could add a note to AAM mentioning that so it doesn't come up again... If that's not correct, we can update the mapping.

@cookiecrook
Copy link
Contributor

Thanks Joanie. PR #107

@jnurthen
Copy link
Member

@spectranaut should this be merged into stable? Are there implementations and tests?

@jnurthen jnurthen reopened this Jun 22, 2022
spectranaut added a commit to spectranaut/wpt that referenced this issue Jul 8, 2022
@spectranaut
Copy link
Contributor

spectranaut commented Jul 8, 2022

Looks like there are two implementations:

I just opened a PR with the test change: web-platform-tests/wpt#34758

@spectranaut spectranaut added ready-for-stable tests + two implementatoins and removed ready-for-stable tests + two implementatoins labels Jul 8, 2022
spectranaut added a commit to web-platform-tests/wpt that referenced this issue Aug 17, 2023
* CORE-AAM: AXAPI subrole for role=tab

See issue: w3c/core-aam#106

* CORE-AAM: unnamed forms are not landmarks

See issue: w3c/core-aam#11

* CORE-AAM: add tests for role comment

See issue: w3c/core-aam#62
whimboo pushed a commit to web-platform-tests/wpt that referenced this issue Aug 22, 2023
* CORE-AAM: AXAPI subrole for role=tab

See issue: w3c/core-aam#106

* CORE-AAM: unnamed forms are not landmarks

See issue: w3c/core-aam#11

* CORE-AAM: add tests for role comment

See issue: w3c/core-aam#62
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 13, 2023
Automatic update from web-platform-tests
Update CORE-AAM tests (#34758)

* CORE-AAM: AXAPI subrole for role=tab

See issue: w3c/core-aam#106

* CORE-AAM: unnamed forms are not landmarks

See issue: w3c/core-aam#11

* CORE-AAM: add tests for role comment

See issue: w3c/core-aam#62
--

wpt-commits: 7e6c12c6f5eaa3df840a595b2ff9de730dc58a3d
wpt-pr: 34758
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Sep 14, 2023
Automatic update from web-platform-tests
Update CORE-AAM tests (#34758)

* CORE-AAM: AXAPI subrole for role=tab

See issue: w3c/core-aam#106

* CORE-AAM: unnamed forms are not landmarks

See issue: w3c/core-aam#11

* CORE-AAM: add tests for role comment

See issue: w3c/core-aam#62
--

wpt-commits: 7e6c12c6f5eaa3df840a595b2ff9de730dc58a3d
wpt-pr: 34758
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023
* CORE-AAM: AXAPI subrole for role=tab

See issue: w3c/core-aam#106

* CORE-AAM: unnamed forms are not landmarks

See issue: w3c/core-aam#11

* CORE-AAM: add tests for role comment

See issue: w3c/core-aam#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-not-in-stable ready-for-stable tests + two implementatoins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants