Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language switching doesn't work for the spec metadata #392

Closed
xfq opened this issue Oct 8, 2021 · 5 comments · Fixed by #393
Closed

Language switching doesn't work for the spec metadata #392

xfq opened this issue Oct 8, 2021 · 5 comments · Fixed by #393

Comments

@xfq
Copy link
Member

xfq commented Oct 8, 2021

After clicking 简体中文 in https://w3c.github.io/clreq/, the spec content is changed to SC, but the spec metadata section ("This version:", "Latest published version:", "Latest editor's draft:", "Editors:" etc.) is still in English.

This may be related to recent changes in ReSpec.

@xfq
Copy link
Member Author

xfq commented Oct 8, 2021

"Abstract" and "Status of This Document" are also in English.

@r12a
Copy link
Contributor

r12a commented Oct 8, 2021

Looks like we may need to raise an issue in the Respec repo.

@xfq
Copy link
Member Author

xfq commented Oct 9, 2021

I just took a look and changed this line:

clreq/script.js

Line 136 in df5729b

$$('h1 + h2 + dl dt')

to $$('h1 + h2 + details dl dt') and the problem was solved. However, "More details about this document" is still in English because our script does not currently support the localization of the summary element.

xfq added a commit that referenced this issue Oct 9, 2021
@xfq
Copy link
Member Author

xfq commented Oct 9, 2021

I just sent #393 to fix this.

@xfq
Copy link
Member Author

xfq commented Oct 9, 2021

IMHO when ReSpec changes the markup structure of the spec metadata section, it is best to make an announcement (to [email protected], maybe) so that downstream specs that rely on the markup structure can better adapt to the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants