Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many HTTP URLs that could/should be HTTPS #55

Closed
foolip opened this issue May 27, 2020 · 5 comments
Closed

Many HTTP URLs that could/should be HTTPS #55

foolip opened this issue May 27, 2020 · 5 comments

Comments

@tidoust
Copy link
Member

tidoust commented May 27, 2020

First few ones (those that target Editor's Drafts) have been fixed upstream in W3C systems and released in v1.2.0.

The remaining ones cannot be fixed upstream today, because the same info is used to maintain the tr.rdf file where the HTTP URL appears (because these specs have been published before we switched to HTTPS everywhere). Switching a URL from HTTP to HTTPS in RDF means that you're no longer talking about the same subject, which could break tools that make use of that info.

I don't think we're tied to the same strict rules here, so perhaps we can just force the switch to HTTPS when we retrieve the info from the W3C API.

@foolip
Copy link
Member Author

foolip commented May 27, 2020

Simply normalizing all URLs and changing the protocol to HTTPS would work, right?

@tidoust
Copy link
Member

tidoust commented May 27, 2020

Right, I don't even think that we need to parse strings as URLs in practice. Replacing http: by https: at the beginning of the string should be all it takes.

@foolip
Copy link
Member Author

foolip commented May 27, 2020

That would do the trick, yeah :)

tidoust added a commit to tidoust/browser-specs that referenced this issue May 29, 2020
This update contains the following changes:

- HTTP URLs from the W3C API and Specref are now automatically switched to
HTTPS URLs. Switches get reported as warnings to the console. See w3c#55.
- CSS Forms Styling was dropped. See w3c#56.
- W3C API redirect reponses generate a proper error message. See w3c#60.
- A number of missing specs signaled in w3c#58 have been added.
tidoust added a commit to tidoust/browser-specs that referenced this issue May 29, 2020
This update contains the following changes:

- HTTP URLs from the W3C API and Specref are now automatically switched to
HTTPS URLs. Switches get reported as warnings to the console. See w3c#55.
- CSS Forms Styling was dropped. See w3c#56.
- W3C API redirect reponses generate a proper error message. See w3c#60.
- A number of missing specs signaled in w3c#58 have been added.
- A couple of tests were added to detect shortname collisions, and the presence
of non-HTTPS URLs in index.json
tidoust added a commit that referenced this issue May 29, 2020
* Force HTTPS URLs, drop CSS Forms, add specs

This update contains the following changes:

- HTTP URLs from the W3C API and Specref are now automatically switched to
HTTPS URLs. Switches get reported as warnings to the console. See #55.
- CSS Forms Styling was dropped. See #56.
- W3C API redirect reponses generate a proper error message. See #60.
- A number of missing specs signaled in #58 have been added.
- A couple of tests were added to detect shortname collisions, and the presence
of non-HTTPS URLs in index.json

* Add index.json (needed to make tests pass)

Previous commit changed the constraints on index.json so new file needs to be
included in the PR.
@tidoust
Copy link
Member

tidoust commented May 29, 2020

All HTTP URLs returned by the W3C API are now automatically converted to HTTPS, and a test ensures that there is no HTTP URL in index.json.

@tidoust tidoust closed this as completed May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants