Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec rewrite to address open issues #98

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Spec rewrite to address open issues #98

merged 2 commits into from
Mar 24, 2023

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Dec 20, 2022 •
edited
Loading

This PR...

  • Drops setClientBadge() and clearClientBadge() due to limited implementer interest.
  • Removes dependency on Service Worker - the API is available in any “worker” context.
  • For Window context, added document is fully active check.
  • Matches Chrome’s behavior or exposing the API to the Web, but making it a no-op when an app is not installed.
  • Add fully active check for document in Window context.
  • Leaves actual display on badging to the end-user.

closes #95
closes #94
closes #93
closes #92
closes #66
closes #44

Preview | Diff

@marcoscaceres marcoscaceres marked this pull request as draft December 20, 2022 06:33
@marcoscaceres marcoscaceres marked this pull request as ready for review March 24, 2023 06:22
@marcoscaceres marcoscaceres merged commit 32bbf60 into main Mar 24, 2023
@marcoscaceres marcoscaceres deleted the drop_setClientBadge branch April 11, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@marcoscaceres