-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Badge from interface to namespace #38
Conversation
This LGTM :) |
@domenic, this is my first ever attempt at defining a namespace 🐣... anything else we would need to spec that's different from an interface definition? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs [Exposed].
Ah, yeah of course. Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I would also change all "X method"s to "X function"s. (Both are Web IDL "operations", but you are doing the nice thing for web devs and using the normal JavaScript name, which with this change would now be function.)
I wondered about that... I was mostly following the naming form the console API, which calls them "methods". Don't feel strongly about changing it, but my working assumption is: if the operations attached to an object, then it's a "method" on that object. Otherwise, it's a standalone operations, so it's a "function". |
Good point, we should fix console. (Methods are |
Sounds good. I'll update this PR. |
Feel free to merge :) |
closes #9
closes #14
Preview | Diff