Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Simplify Badging API for first attempt #16

Merged
merged 4 commits into from
Dec 11, 2018

Conversation

fallaciousreasoning
Copy link
Collaborator

@fallaciousreasoning fallaciousreasoning commented Dec 5, 2018

Changes

  • Remove string/grapheme badges.
    • Not supported on iOS/Android
    • Windows API only gives us 16x16 pixels to play with, so they'll be hard to see.
  • Move Service Worker out of initial attempt. API needs more thought
    • Service worker scope isn't necessarily the same as PWA scope. Which PWA do we badge if a service worker has multiple PWAs installed?
    • Some platforms (Windows 7) only support badging for an open app window.

explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Show resolved Hide resolved
explainer.md Show resolved Hide resolved
explainer.md Show resolved Hide resolved
explainer.md Show resolved Hide resolved
@mgiuca
Copy link
Collaborator

mgiuca commented Dec 6, 2018

Also could you update the description:

  • Link to Remove strings from the first version of this API #17 which I just filed for this issue.
  • Rephrase, avoiding "what is actually being implemented". We aren't thinking of it as a "spec follows implementation" (since Chrome is just one possible implementation). In fact we could easily have implemented the character part; this change is being driven by feedback we've received from the intent-to-implement saying we should start with a simpler API surface. So rather, say we are simplifying the API for the first attempt.

@fallaciousreasoning fallaciousreasoning changed the title WIP: Updates the explainer to reflect what is actually being implemented WIP: Simplify Badging API for first attempt Dec 6, 2018
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mgiuca mgiuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, please make one minor change requested below.

explainer.md Outdated Show resolved Hide resolved
@mgiuca mgiuca merged commit 3a60431 into w3c:master Dec 11, 2018
@mgiuca
Copy link
Collaborator

mgiuca commented Dec 11, 2018

Merged, thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants