-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aria-expanded: revise definition and change applicability for issue 681 #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue #681 by: * Revising aria-expanded definition to state it aria-expanded belongs on interactive, focusable, controlling element. * Rewording normative authors SHOULD to clarify when aria-controls should be used. * Trimming unnecessary content from aria-expanded description related to grouping mechanisms and the benefits of collapsing content. * Removing support from document, section, sectionhead, and window. * Restoring support to following subclass roles that were effected by removals: gridcell, listbox (for issue #722), row, rowheader, tab, and treeitem. * Adding support for checkbox. Thus, support is removed from the roles listed below that do not act as interactive, focusable, controlling mechanisms for expansion: alert alertdialog article banner blockquote caption cell complementary contentinfo definition deletion dialog directory feed figure form grid group heading img insertion label landmark legend list listitem log main marquee math menu menubar navigation note paragraph radiogroup region search select status subscript superscript table tabpanel term time timer toolbar tooltip tree treegrid
joanmarie
pushed a commit
that referenced
this pull request
Sep 4, 2019
…81 (#972) * aria-expanded: revise definition and change applicability Resolves issue #681 by: * Revising aria-expanded definition to state it aria-expanded belongs on interactive, focusable, controlling element. * Rewording normative authors SHOULD to clarify when aria-controls should be used. * Trimming unnecessary content from aria-expanded description related to grouping mechanisms and the benefits of collapsing content. * Removing support from document, section, sectionhead, and window. * Restoring support to following subclass roles that were effected by removals: gridcell, listbox (for issue #722), row, rowheader, tab, and treeitem. * Adding support for checkbox. * Adding aria-expanded as supported for role application Thus, support is removed from the roles listed below that do not act as interactive, focusable, controlling mechanisms for expansion: alert alertdialog article banner blockquote caption cell complementary contentinfo definition deletion dialog directory feed figure form grid group heading img insertion label landmark legend list listitem log main marquee math menu menubar navigation note paragraph radiogroup region search select status subscript superscript table tabpanel term time timer toolbar tooltip tree treegrid
carmacleod
pushed a commit
that referenced
this pull request
Oct 17, 2019
…81 (#972) * aria-expanded: revise definition and change applicability Resolves issue #681 by: * Revising aria-expanded definition to state it aria-expanded belongs on interactive, focusable, controlling element. * Rewording normative authors SHOULD to clarify when aria-controls should be used. * Trimming unnecessary content from aria-expanded description related to grouping mechanisms and the benefits of collapsing content. * Removing support from document, section, sectionhead, and window. * Restoring support to following subclass roles that were effected by removals: gridcell, listbox (for issue #722), row, rowheader, tab, and treeitem. * Adding support for checkbox. * Adding aria-expanded as supported for role application Thus, support is removed from the roles listed below that do not act as interactive, focusable, controlling mechanisms for expansion: alert alertdialog article banner blockquote caption cell complementary contentinfo definition deletion dialog directory feed figure form grid group heading img insertion label landmark legend list listitem log main marquee math menu menubar navigation note paragraph radiogroup region search select status subscript superscript table tabpanel term time timer toolbar tooltip tree treegrid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #681 by:
Thus, support is removed from the roles listed below that do not act as interactive, focusable, controlling mechanisms for expansion:
alert
alertdialog
article
banner
blockquote
caption
cell
complementary
contentinfo
definition
deletion
dialog
directory
feed
figure
form
grid
group
heading
img
insertion
label
landmark
legend
list
listitem
log
main
marquee
math
menu
menubar
navigation
note
paragraph
radiogroup
region
search
select
status
subscript
superscript
table
tabpanel
term
time
timer
toolbar
tooltip
tree
treegrid
Link to preview these changes
raw.githack view of branch
Preview | Diff