Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-expanded: revise definition and change applicability for issue 681 #972

Merged
merged 6 commits into from
May 2, 2019

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented May 2, 2019

Resolves issue #681 by:

  • Revising aria-expanded definition to state it aria-expanded belongs on interactive, focusable, controlling element.
  • Rewording normative authors SHOULD to clarify when aria-controls should be used.
  • Trimming unnecessary content from aria-expanded description related to grouping mechanisms and the benefits of collapsing content.
  • Removing support from document, section, sectionhead, and window.
  • Restoring support to following subclass roles that were effected by removals: gridcell, listbox (for issue Add aria-expanded as a supported property of listbox #722), row, rowheader, tab, and treeitem.
  • Adding support for checkbox.

Thus, support is removed from the roles listed below that do not act as interactive, focusable, controlling mechanisms for expansion:

alert
alertdialog
article
banner
blockquote
caption
cell
complementary
contentinfo
definition
deletion
dialog
directory
feed
figure
form
grid
group
heading
img
insertion
label
landmark
legend
list
listitem
log
main
marquee
math
menu
menubar
navigation
note
paragraph
radiogroup
region
search
select
status
subscript
superscript
table
tabpanel
term
time
timer
toolbar
tooltip
tree
treegrid

Link to preview these changes

raw.githack view of branch


Preview | Diff

Resolves issue #681 by:
* Revising aria-expanded definition to state it aria-expanded belongs on interactive, focusable, controlling element.
* Rewording normative authors SHOULD to clarify when aria-controls should be used.
* Trimming unnecessary content from aria-expanded description related to grouping mechanisms and the benefits of collapsing content.
* Removing support from document, section, sectionhead, and window.
* Restoring support to following subclass roles that were effected by removals: gridcell, listbox (for issue #722), row, rowheader, tab, and treeitem.
* Adding support for checkbox.

Thus, support is removed from the roles listed below that do not act as interactive, focusable, controlling mechanisms for expansion:

alert
alertdialog
article
banner
blockquote
caption
cell
complementary
contentinfo
definition
deletion
dialog
directory
feed
figure
form
grid
group
heading
img
insertion
label
landmark
legend
list
listitem
log
main
marquee
math
menu
menubar
navigation
note
paragraph
radiogroup
region
search
select
status
subscript
superscript
table
tabpanel
term
time
timer
toolbar
tooltip
tree
treegrid
@joanmarie joanmarie merged commit 6aed776 into master May 2, 2019
joanmarie pushed a commit that referenced this pull request Sep 4, 2019
…81 (#972)

* aria-expanded: revise definition and change applicability

Resolves issue #681 by:
* Revising aria-expanded definition to state it aria-expanded belongs on
  interactive, focusable, controlling element.
* Rewording normative authors SHOULD to clarify when aria-controls should
  be used.
* Trimming unnecessary content from aria-expanded description related to
  grouping mechanisms and the benefits of collapsing content.
* Removing support from document, section, sectionhead, and window.
* Restoring support to following subclass roles that were effected by
  removals: gridcell, listbox (for issue #722), row, rowheader, tab, and
  treeitem.
* Adding support for checkbox.
* Adding aria-expanded as supported for role application

Thus, support is removed from the roles listed below that do not act as
interactive, focusable, controlling mechanisms for expansion:

alert
alertdialog
article
banner
blockquote
caption
cell
complementary
contentinfo
definition
deletion
dialog
directory
feed
figure
form
grid
group
heading
img
insertion
label
landmark
legend
list
listitem
log
main
marquee
math
menu
menubar
navigation
note
paragraph
radiogroup
region
search
select
status
subscript
superscript
table
tabpanel
term
time
timer
toolbar
tooltip
tree
treegrid
carmacleod pushed a commit that referenced this pull request Oct 17, 2019
…81 (#972)

* aria-expanded: revise definition and change applicability

Resolves issue #681 by:
* Revising aria-expanded definition to state it aria-expanded belongs on interactive, focusable, controlling element.
* Rewording normative authors SHOULD to clarify when aria-controls should be used.
* Trimming unnecessary content from aria-expanded description related to grouping mechanisms and the benefits of collapsing content.
* Removing support from document, section, sectionhead, and window.
* Restoring support to following subclass roles that were effected by removals: gridcell, listbox (for issue #722), row, rowheader, tab, and treeitem.
* Adding support for checkbox.
* Adding aria-expanded as supported for role application

Thus, support is removed from the roles listed below that do not act as interactive, focusable, controlling mechanisms for expansion:

alert
alertdialog
article
banner
blockquote
caption
cell
complementary
contentinfo
definition
deletion
dialog
directory
feed
figure
form
grid
group
heading
img
insertion
label
landmark
legend
list
listitem
log
main
marquee
math
menu
menubar
navigation
note
paragraph
radiogroup
region
search
select
status
subscript
superscript
table
tabpanel
term
time
timer
toolbar
tooltip
tree
treegrid
@jnurthen jnurthen deleted the issue681-aria-expanded-scope branch July 23, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants