Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Aria Orientation on scrollbar to supported section (from required) #781

Closed
wants to merge 1 commit into from
Closed

Move Aria Orientation on scrollbar to supported section (from required) #781

wants to merge 1 commit into from

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Jun 6, 2018 •
edited by pr-preview bot
Loading

@jnurthen
Copy link
Member Author

jnurthen commented Jun 6, 2018

When merged will fix #780

@joanmarie joanmarie self-requested a review June 6, 2018 20:11
@joanmarie
Copy link
Contributor

Maybe I'm tired, but I'm not seeing where I can explicitly review this. That said, I disagree with the change as indicated in #780. Please explain why we want to make aria-orientation a non-required property.

joanmarie
joanmarie requested changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@joanmarie joanmarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Aha, reloading the page caused this to show up)

As I commented, I in #780, I don't think we want to make this change here -- at least not until further clarification is provided so that I understand the issue better.

@joanmarie
Copy link
Contributor

BTW, nit: We have historically (and imho want to continue to) add ChangeLog entries with the most recent at the top. I hadn't noticed that this didn't occur with the IDL / reflection merge. So once we determine what changes we want to make to fix the issue associated with the pull request, mind also moving the changelog entries so that the most recent are at the top? Thanks!

@jnurthen jnurthen added the WIP label Nov 27, 2018
@jnurthen
Copy link
Member Author

This is superseded by #858

@jnurthen jnurthen closed this Sep 27, 2019
@jnurthen jnurthen deleted the Issue780---aria-orientation-required-on-scrollbar branch July 23, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanmarie joanmarie joanmarie requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnurthen @joanmarie